aboutsummaryrefslogtreecommitdiff
path: root/devel/kf5-kio/Makefile
diff options
context:
space:
mode:
authorTobias C. Berner <tcberner@FreeBSD.org>2020-05-24 20:22:13 +0000
committerTobias C. Berner <tcberner@FreeBSD.org>2020-05-24 20:22:13 +0000
commitda9ed866a567714667dc0937a7af316ee4913129 (patch)
tree2fd05253d90a67f4362acee71853689e9c5e7809 /devel/kf5-kio/Makefile
parent1ac21e9294818af15eec85678cff32635477e330 (diff)
downloadports-da9ed866a567714667dc0937a7af316ee4913129.tar.gz
ports-da9ed866a567714667dc0937a7af316ee4913129.zip
devel/kf5-kio: add upstream bug fix: "Could not find the program ‘konsole’"
From upstrams [1] bug report Fix service file specifying 'Run in terminal' giving an error code 100 Happens because KIO::DesktopExecParser::resultingArguments() prepends the terminal application to the command line. If this is a relative path, as it is most likely to be (and will be in the default 'konsole' case), the "realExecutable" check in KProcessRunner::KProcessRunner() is triggered and the job aborts with an error. Expand the specified terminal executable into a full path in resultingArguments(), and return an error immediately if it cannot be found. This full terminal path is not relative for the KProcessRunner::KProcessRunner() check and does not fail. Check that resultingArguments() is not empty (an error return) before accessing the first word of the command, so that it does not assert if the list is empty. Also only call resultingArguments() once. [1] https://bugs.kde.org/show_bug.cgi?id=421374 PR: 246659 Reported by: Serge Volkov <sv@ulstu.ru>
Notes
Notes: svn path=/head/; revision=536419
Diffstat (limited to 'devel/kf5-kio/Makefile')
-rw-r--r--devel/kf5-kio/Makefile1
1 files changed, 1 insertions, 0 deletions
diff --git a/devel/kf5-kio/Makefile b/devel/kf5-kio/Makefile
index 82b6b5beeaf1..c8f6f23bc478 100644
--- a/devel/kf5-kio/Makefile
+++ b/devel/kf5-kio/Makefile
@@ -2,6 +2,7 @@
PORTNAME= kio
DISTVERSION= ${KDE_FRAMEWORKS_VERSION}
+PORTREVISION= 1
KDE_FRAMEWORKS_VERSION= 5.70.1
CATEGORIES= devel kde kde-frameworks