From da9ed866a567714667dc0937a7af316ee4913129 Mon Sep 17 00:00:00 2001 From: "Tobias C. Berner" Date: Sun, 24 May 2020 20:22:13 +0000 Subject: =?UTF-8?q?devel/kf5-kio:=20add=20upstream=20bug=20fix:=20"Could?= =?UTF-8?q?=20not=20find=20the=20program=20=E2=80=98konsole=E2=80=99"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From upstrams [1] bug report Fix service file specifying 'Run in terminal' giving an error code 100 Happens because KIO::DesktopExecParser::resultingArguments() prepends the terminal application to the command line. If this is a relative path, as it is most likely to be (and will be in the default 'konsole' case), the "realExecutable" check in KProcessRunner::KProcessRunner() is triggered and the job aborts with an error. Expand the specified terminal executable into a full path in resultingArguments(), and return an error immediately if it cannot be found. This full terminal path is not relative for the KProcessRunner::KProcessRunner() check and does not fail. Check that resultingArguments() is not empty (an error return) before accessing the first word of the command, so that it does not assert if the list is empty. Also only call resultingArguments() once. [1] https://bugs.kde.org/show_bug.cgi?id=421374 PR: 246659 Reported by: Serge Volkov --- devel/kf5-kio/Makefile | 1 + 1 file changed, 1 insertion(+) (limited to 'devel/kf5-kio/Makefile') diff --git a/devel/kf5-kio/Makefile b/devel/kf5-kio/Makefile index 82b6b5beeaf1..c8f6f23bc478 100644 --- a/devel/kf5-kio/Makefile +++ b/devel/kf5-kio/Makefile @@ -2,6 +2,7 @@ PORTNAME= kio DISTVERSION= ${KDE_FRAMEWORKS_VERSION} +PORTREVISION= 1 KDE_FRAMEWORKS_VERSION= 5.70.1 CATEGORIES= devel kde kde-frameworks -- cgit v1.2.3