diff options
| author | Doug Moore <dougm@FreeBSD.org> | 2024-07-18 18:56:31 +0000 |
|---|---|---|
| committer | Doug Moore <dougm@FreeBSD.org> | 2024-07-18 18:56:31 +0000 |
| commit | a527b9cb721a597a0bc5313ac55290cc6a91deac (patch) | |
| tree | e424a46f59585861bfc5acf4bb093c9d1b3b78ad | |
| parent | ee912ee57a213b25fc9e559054e5869b4a6b2f61 (diff) | |
| download | src-a527b9cb721a597a0bc5313ac55290cc6a91deac.tar.gz src-a527b9cb721a597a0bc5313ac55290cc6a91deac.zip | |
axgbe: use standard rounddown_pow_of_two
Drop an implementation of __rounddown_pow_of_two, which triggers
Coverity warnings, and use the libkern implementation of
rounddown_pow_of_two instead.
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D46022
| -rw-r--r-- | sys/dev/axgbe/xgbe-sysctl.c | 20 |
1 files changed, 2 insertions, 18 deletions
diff --git a/sys/dev/axgbe/xgbe-sysctl.c b/sys/dev/axgbe/xgbe-sysctl.c index 16523381e1a3..df81b1d7f0ae 100644 --- a/sys/dev/axgbe/xgbe-sysctl.c +++ b/sys/dev/axgbe/xgbe-sysctl.c @@ -244,22 +244,6 @@ exit_bad_op(void) return(-EINVAL); } -static inline unsigned -fls_long(unsigned long l) -{ - - if (sizeof(l) == 4) - return (fls(l)); - return (fls64(l)); -} - -static inline __attribute__((const)) -unsigned long __rounddown_pow_of_two(unsigned long n) -{ - - return (1UL << (fls_long(n) - 1)); -} - static inline int get_ubuf(struct sysctl_req *req, char *ubuf) { @@ -1049,12 +1033,12 @@ sysctl_ringparam_handler(SYSCTL_HANDLER_ARGS) return (-EINVAL); } - rx = __rounddown_pow_of_two(sys_op->rx_pending); + rx = rounddown_pow_of_two(sys_op->rx_pending); if (rx != sys_op->rx_pending) axgbe_printf(1, "rx ring param rounded to power of 2: %u\n", rx); - tx = __rounddown_pow_of_two(sys_op->tx_pending); + tx = rounddown_pow_of_two(sys_op->tx_pending); if (tx != sys_op->tx_pending) axgbe_printf(1, "tx ring param rounded to power of 2: %u\n", tx); |