aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEd Maste <emaste@FreeBSD.org>2024-10-31 15:51:29 +0000
committerEd Maste <emaste@FreeBSD.org>2024-11-05 04:19:58 +0000
commitd0dcee46d971c79257be42b0e50cd9183c79fcbb (patch)
treecbf75c896c6f76baded2c24eb4624df3ff46606e
parentbc01ae40e45efca283ea7c2b5d5c8549adfb340f (diff)
libcxxrt: Update to upstream 6f2fdfebcd62
Interesting fixes: 3cbfe5a556fe Avoid noreturn warning on terminate() (cherry picked from commit 2dccd21949f26b1bdf5e7cf258b760fffd3bf259) (cherry picked from commit d9901a23bd2f4e6aeef7f628f946134c4698fc38) Approved by: re (cperciva)
-rw-r--r--contrib/libcxxrt/exception.cc26
1 files changed, 16 insertions, 10 deletions
diff --git a/contrib/libcxxrt/exception.cc b/contrib/libcxxrt/exception.cc
index c87fe5ac4468..5034809a1380 100644
--- a/contrib/libcxxrt/exception.cc
+++ b/contrib/libcxxrt/exception.cc
@@ -237,7 +237,7 @@ static_assert(offsetof(__cxa_dependent_exception, unwindHeader) ==
namespace std
{
- void unexpected();
+ [[noreturn]] void unexpected();
class exception
{
public:
@@ -1530,28 +1530,34 @@ namespace std
if (0 != info && 0 != info->terminateHandler)
{
info->terminateHandler();
- // Should not be reached - a terminate handler is not expected to
- // return.
- abort();
}
- terminateHandler.load()();
+ else
+ {
+ terminateHandler.load()();
+ }
+ // Should not be reached - a terminate handler is not expected
+ // to return.
+ abort();
}
/**
* Called when an unexpected exception is encountered (i.e. an exception
* violates an exception specification). This calls abort() unless a
* custom handler has been set..
*/
- void unexpected()
+ [[noreturn]] void unexpected()
{
static __cxa_thread_info *info = thread_info();
if (0 != info && 0 != info->unexpectedHandler)
{
info->unexpectedHandler();
- // Should not be reached - a terminate handler is not expected to
- // return.
- abort();
}
- unexpectedHandler.load()();
+ else
+ {
+ unexpectedHandler.load()();
+ }
+ // Should not be reached - a unexpected handler is not expected
+ // to return.
+ abort();
}
/**
* Returns whether there are any exceptions currently being thrown that