diff options
| author | Warner Losh <imp@FreeBSD.org> | 2026-02-02 13:30:08 +0000 |
|---|---|---|
| committer | Warner Losh <imp@FreeBSD.org> | 2026-02-02 13:31:21 +0000 |
| commit | 05322eec86ae42a8f873ba10d8da61bd61b5b48f (patch) | |
| tree | a8695de1a209f785886ec147b821ff609d738a2b | |
| parent | e63ee5fedb8dab51f1bd6d24cc650b68d9663db5 (diff) | |
nvmecontrol: Always set the RAE bit on telemetry-log requests
nvme-cli, as well as some vendor scripts, always set the RAE bit of the
GET LOG PAGE request when retrieving telemetry logs to avoid the log
getting reset to something new. Adopt that praactice here (nvme-cli
telemetry-log does have a --rae option, but that just turns on the rae
bit which defaults to being on: there's no way to turn it off).
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D55017
| -rw-r--r-- | sbin/nvmecontrol/telemetry.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sbin/nvmecontrol/telemetry.c b/sbin/nvmecontrol/telemetry.c index 72c304229a80..bfa1325974d5 100644 --- a/sbin/nvmecontrol/telemetry.c +++ b/sbin/nvmecontrol/telemetry.c @@ -136,7 +136,7 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) /* Read the log page */ size = sizeof(tlp); off = 0; - read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, 0, + read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, off, 0, 0, 0, &tlp, size); switch(opt.da) { case 1: @@ -158,7 +158,7 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) do { if (chunk > size) chunk = size; - read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, 0, + read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, off, 0, 0, 0, &buf, chunk); if (off == 0) { /* |