diff options
| author | Siva Mahadevan <siva@FreeBSD.org> | 2026-06-17 17:04:54 +0000 |
|---|---|---|
| committer | Siva Mahadevan <siva@FreeBSD.org> | 2026-06-17 17:04:54 +0000 |
| commit | 19af9c77acc912e4bf90a667924f5f4ff78a7759 (patch) | |
| tree | 57419dd0bb4b2910489db4e26739244d1f937ff5 | |
| parent | 1294f332aec02e111b47d69e0d91e32dc2624001 (diff) | |
msun/logarithm_test: expect_fail log1p_accuracy_tests in the correct spot
While here, remove the conditional on the "ci" config var to ensure that
this is reproducible locally as well.
This fixes a case where we are expecting a fail before the failing ATF_CHECK_*
assertion happens. Found in a CI failure here:
https://ci.freebsd.org/job/FreeBSD-main-riscv64-test/16608/testReport/lib.msun/logarithm_test/log1p_accuracy_tests/
PR: 253984
Fixes: 405188aeac540f7666dfde37c2f32d222119f56e
MFC after: 3 days
Differential Revision: https://reviews.freebsd.org/D57351
| -rw-r--r-- | lib/msun/tests/logarithm_test.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/lib/msun/tests/logarithm_test.c b/lib/msun/tests/logarithm_test.c index df1fcdc8627d..a605fa6a6bfc 100644 --- a/lib/msun/tests/logarithm_test.c +++ b/lib/msun/tests/logarithm_test.c @@ -249,10 +249,6 @@ ATF_TC_BODY(accuracy_tests, tc) ATF_TC_WITHOUT_HEAD(log1p_accuracy_tests); ATF_TC_BODY(log1p_accuracy_tests, tc) { -#if LDBL_MANT_DIG > 64 - if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false)) - atf_tc_expect_fail("https://bugs.freebsd.org/253984"); -#endif #if defined(__riscv) atf_tc_expect_death("https://bugs.freebsd.org/290099"); #endif @@ -260,6 +256,9 @@ ATF_TC_BODY(log1p_accuracy_tests, tc) 1.82321546859847114303367992804596800640e-1L, FLT_ULP()); test_tol(log1p, 0x0.3333333333333p0, 1.82321556793954589204283870982629267635e-1L, DBL_ULP()); +#if LDBL_MANT_DIG > 64 + atf_tc_expect_fail("https://bugs.freebsd.org/253984"); +#endif test_tol(log1pl, 0x0.33333333333333332p0L, 1.82321556793954626202683007050468762914e-1L, LDBL_ULP()); |