diff options
| author | Ed Maste <emaste@FreeBSD.org> | 2026-05-22 00:50:00 +0000 |
|---|---|---|
| committer | Ed Maste <emaste@FreeBSD.org> | 2026-05-22 14:21:11 +0000 |
| commit | 1a4ad649cb135501f0bee56a4214e8c904ca402e (patch) | |
| tree | dc49d70b75dc564e0a6f3db26ecf2bba3f7efcb6 | |
| parent | 0b2df683672e3b5792aa552a3700da86617f9d90 (diff) | |
netlink: Avoid undefined behaviour
Even though it is not dereferenced, it is UB to take the address of an
out of bounds array element.
Reviewed by: pouria, bz, des, adrian
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D57158
| -rw-r--r-- | sys/netlink/netlink_generic.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c index fb74860e42b3..c2f82eed5656 100644 --- a/sys/netlink/netlink_generic.c +++ b/sys/netlink/netlink_generic.c @@ -127,13 +127,13 @@ genl_handle_message(struct nlmsghdr *hdr, struct nl_pstate *npt) } family_id = hdr->nlmsg_type - GENL_MIN_ID; - gf = &families[family_id]; if (__predict_false(family_id >= MAX_FAMILIES || - gf->family_name == NULL)) { + families[family_id].family_name == NULL)) { NLP_LOG(LOG_DEBUG, nlp, "invalid message type: %d", hdr->nlmsg_type); return (ENOTSUP); } + gf = &families[family_id]; struct genlmsghdr *ghdr = (struct genlmsghdr *)(hdr + 1); |