diff options
| author | Andrew Rybchenko <arybchik@FreeBSD.org> | 2018-11-23 11:31:45 +0000 |
|---|---|---|
| committer | Andrew Rybchenko <arybchik@FreeBSD.org> | 2018-11-23 11:31:45 +0000 |
| commit | 1b5bd0997a2c6b54ca9f135cc9a9e5bd5ce42d8c (patch) | |
| tree | 2c18f5a183c0865fad8767a1b727409ab8fefc7e | |
| parent | e7144483bb31ff3bc701a6d7c56db78c1a815ca8 (diff) | |
| download | src-1b5bd0997a2c6b54ca9f135cc9a9e5bd5ce42d8c.tar.gz src-1b5bd0997a2c6b54ca9f135cc9a9e5bd5ce42d8c.zip | |
sfxge(4): fix ignoring function return value
fix PreFAST issue, add missing annotation that function return value
should not be ignored. Fix alignment.
Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week
Differential Revision: https://reviews.freebsd.org/D18096
Notes
Notes:
svn path=/head/; revision=340826
| -rw-r--r-- | sys/dev/sfxge/common/efx.h | 12 | ||||
| -rw-r--r-- | sys/dev/sfxge/common/efx_phy.c | 2 |
2 files changed, 7 insertions, 7 deletions
diff --git a/sys/dev/sfxge/common/efx.h b/sys/dev/sfxge/common/efx.h index 926e8a0bf8c1..6f4d45595a17 100644 --- a/sys/dev/sfxge/common/efx.h +++ b/sys/dev/sfxge/common/efx.h @@ -920,13 +920,13 @@ efx_phy_media_type_get( __in efx_nic_t *enp, __out efx_phy_media_type_t *typep); -extern efx_rc_t +extern __checkReturn efx_rc_t efx_phy_module_get_info( - __in efx_nic_t *enp, - __in uint8_t dev_addr, - __in uint8_t offset, - __in uint8_t len, - __out_bcount(len) uint8_t *data); + __in efx_nic_t *enp, + __in uint8_t dev_addr, + __in uint8_t offset, + __in uint8_t len, + __out_bcount(len) uint8_t *data); #if EFSYS_OPT_PHY_STATS diff --git a/sys/dev/sfxge/common/efx_phy.c b/sys/dev/sfxge/common/efx_phy.c index 13f7a75d4c81..74f481a6002e 100644 --- a/sys/dev/sfxge/common/efx_phy.c +++ b/sys/dev/sfxge/common/efx_phy.c @@ -301,7 +301,7 @@ efx_phy_media_type_get( *typep = epp->ep_fixed_port_type; } - __checkReturn efx_rc_t + __checkReturn efx_rc_t efx_phy_module_get_info( __in efx_nic_t *enp, __in uint8_t dev_addr, |