aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Baldwin <jhb@FreeBSD.org>2025-12-02 15:57:08 +0000
committerJohn Baldwin <jhb@FreeBSD.org>2025-12-02 15:57:08 +0000
commit44d6df4f65b1441cf9cd9f12cd41edd52205d084 (patch)
treec9bfea91db5494c35d4116dcaa74a09de772208a
parent07d5a9b1b2dd95d95137c6c2afcb84ad40c05b75 (diff)
nvme: Use memcpy instead of memmove in nvme_cdata_get_disk_ident
These buffers should not overlap. Reviewed by: imp Sponsored by: Chelsio Communications Differential Revision: https://reviews.freebsd.org/D53842
-rw-r--r--sys/dev/nvme/nvme.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/nvme/nvme.h b/sys/dev/nvme/nvme.h
index b696cc6aa697..b09fa44b0329 100644
--- a/sys/dev/nvme/nvme.h
+++ b/sys/dev/nvme/nvme.h
@@ -2005,7 +2005,7 @@ nvme_cdata_get_disk_ident(const struct nvme_controller_data *cdata, uint8_t *sn)
_Static_assert(NVME_SERIAL_NUMBER_LENGTH < DISK_IDENT_SIZE,
"NVME serial number too big for disk ident");
- memmove(sn, cdata->sn, NVME_SERIAL_NUMBER_LENGTH);
+ memcpy(sn, cdata->sn, NVME_SERIAL_NUMBER_LENGTH);
sn[NVME_SERIAL_NUMBER_LENGTH] = '\0';
for (int i = 0; sn[i] != '\0'; i++) {
if (sn[i] < 0x20 || sn[i] >= 0x80)