diff options
| author | Warner Losh <imp@FreeBSD.org> | 2025-10-28 22:33:36 +0000 |
|---|---|---|
| committer | Warner Losh <imp@FreeBSD.org> | 2025-10-28 22:35:33 +0000 |
| commit | 471743e1315cdc54d85e3e77b53e3841b3647ea1 (patch) | |
| tree | 0bbc16c233f80c79eaad2d63aec9a6a249416ce2 | |
| parent | 83519c1764f80ddbdf34e16de08ff110226aba2b (diff) | |
nvme: Remove a todo comment
The storage subsystem really wants one of a very small number of I/O
errors. And since we started to do this I/O, EIO is the right error to
return. Other errors may get different and weirder treatment up the
stack, or even converted to just EIO. So remove this TODO comment that's
been there since the initial nvme driver commit. It wouldn't be helpful
to do this, and could likely hurt.
Sponsored by: Netflix
| -rw-r--r-- | sys/dev/nvme/nvme_ns.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/sys/dev/nvme/nvme_ns.c b/sys/dev/nvme/nvme_ns.c index a759181a8c16..f4a588373c98 100644 --- a/sys/dev/nvme/nvme_ns.c +++ b/sys/dev/nvme/nvme_ns.c @@ -142,10 +142,6 @@ nvme_ns_strategy_done(void *arg, const struct nvme_completion *cpl) { struct bio *bp = arg; - /* - * TODO: add more extensive translation of NVMe status codes - * to different bio error codes (i.e. EIO, EINVAL, etc.) - */ if (nvme_completion_is_error(cpl)) { bp->bio_error = EIO; bp->bio_flags |= BIO_ERROR; |
