diff options
| author | John Baldwin <jhb@FreeBSD.org> | 2026-07-31 17:52:42 +0000 |
|---|---|---|
| committer | John Baldwin <jhb@FreeBSD.org> | 2026-07-31 17:52:42 +0000 |
| commit | 486dfbb67e093a461a5ebd97f66be9b345f9de77 (patch) | |
| tree | bdf888e7dbb48a9443fd9d29d24617a26140f878 | |
| parent | b9eaf9b7cef25228e8c20e3819f1b7be94f486aa (diff) | |
kld: Reject kernel modules with PT_LOAD segments where filesz > memsz
All sorts of places in the ELF loading code assume that filesz <=
memsz, so check that explicitly up front.
Reported by: Jane Smith <thebugfixers@pm.me> (via D57785)
Reviewed by: jrtc27, kib
Differential Revision: https://reviews.freebsd.org/D58542
| -rw-r--r-- | sys/kern/link_elf.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/sys/kern/link_elf.c b/sys/kern/link_elf.c index 6ab5f4a39580..d7aeefa25433 100644 --- a/sys/kern/link_elf.c +++ b/sys/kern/link_elf.c @@ -1110,6 +1110,14 @@ link_elf_load_file(linker_class_t cls, const char* filename, error = ENOEXEC; goto out; } + + if (phdr->p_memsz < phdr->p_filesz) { + link_elf_error(filename, + "Invalid program header"); + error = ENOEXEC; + goto out; + } + /* * XXX: We just trust they come in right order ?? */ |