diff options
| author | Michael Tuexen <tuexen@FreeBSD.org> | 2024-12-31 16:26:04 +0000 |
|---|---|---|
| committer | Michael Tuexen <tuexen@FreeBSD.org> | 2024-12-31 16:26:04 +0000 |
| commit | 4f3a0c719780fdd57c660ceb353bbc71fc555600 (patch) | |
| tree | aa790db9af325a6f35db84aa473bd3c8dfcdaf35 | |
| parent | 4940584bbf0b809130f6ac1a7a0c6b00d373af1e (diff) | |
TCP RACK: don't use an uninitialized variable
When storing the old beta values in rack_swap_beta_values(),
ensure that the newreno_flags field is initialized appropriately
instead of using an uninitialized value.
Since the stored newreno_flags aren't actually used, this fix
should not have any functional change.
Reviewed by: rrs
CID: 1523796
MFC after: 1 week
Sponsored by: Netflix, Inc.
Differential Revision: https://reviews.freebsd.org/D48260
| -rw-r--r-- | sys/netinet/tcp_stacks/rack.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/sys/netinet/tcp_stacks/rack.c b/sys/netinet/tcp_stacks/rack.c index da68060dd1d2..ef2554926734 100644 --- a/sys/netinet/tcp_stacks/rack.c +++ b/sys/netinet/tcp_stacks/rack.c @@ -642,6 +642,7 @@ rack_swap_beta_values(struct tcp_rack *rack, uint8_t flex8) failed = 2; goto out; } + old.newreno_flags = CC_NEWRENO_BETA_ECN_ENABLED; /* Get the current values out */ sopt.sopt_valsize = sizeof(struct cc_newreno_opts); sopt.sopt_dir = SOPT_GET; |