diff options
| author | Zhenlei Huang <zlei@FreeBSD.org> | 2025-09-03 17:09:11 +0000 |
|---|---|---|
| committer | Zhenlei Huang <zlei@FreeBSD.org> | 2025-09-03 17:09:11 +0000 |
| commit | 51098f0529f0d1cc532512e0eae9bfcffb8e68e4 (patch) | |
| tree | 6fe385e1a6b48932b357eb9777eb41a08a38d381 | |
| parent | 7e38993247f5e82abd4c347079fd256e73a76a00 (diff) | |
ethernet: Prefer memcmp() over bcmp()
The link-level address and the mbuf shall not overlap. Prefer memcmp()
over bcmp() for slight performance gain.
No functional change intended.
Reviewed by: glebius
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D52345
| -rw-r--r-- | sys/net/if_ethersubr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/net/if_ethersubr.c b/sys/net/if_ethersubr.c index 3ae0c01c0efc..9c157bf3d3c2 100644 --- a/sys/net/if_ethersubr.c +++ b/sys/net/if_ethersubr.c @@ -695,7 +695,7 @@ ether_input_internal(struct ifnet *ifp, struct mbuf *m) * seen by upper protocol layers. */ if (!ETHER_IS_MULTICAST(eh->ether_dhost) && - bcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0) + memcmp(IF_LLADDR(ifp), eh->ether_dhost, ETHER_ADDR_LEN) != 0) m->m_flags |= M_PROMISC; } |