aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGleb Smirnoff <glebius@FreeBSD.org>2026-07-17 01:37:03 +0000
committerGleb Smirnoff <glebius@FreeBSD.org>2026-07-17 01:37:03 +0000
commit56ac3351c61f285ee5b8c9bd4411eeaeb20efe26 (patch)
tree56b20c8eba9bc377cc21378f83336e7f4f01085a
parentf967dd04c880e9c9c68cd20de135d77b3ca1c26d (diff)
witness: fix operation without WITNESS_SKIPSPIN
Since malloc(9) even with M_NOWAIT is forbidden when we hold a spinlock, we can't print detailed lock tree as the operation tries to allocate memory. Fixes: fb4b0c91195195561560bb2fb2c1ba8da81f7ccf
-rw-r--r--sys/kern/subr_witness.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sys/kern/subr_witness.c b/sys/kern/subr_witness.c
index 52f8fa51fd25..92fa8c0799d8 100644
--- a/sys/kern/subr_witness.c
+++ b/sys/kern/subr_witness.c
@@ -1738,7 +1738,8 @@ witness_checkorder(struct lock_object *lock, int flags, const char *file,
"lock order reversal: (Giant after non-sleepable)\n");
else {
witness_output("lock order reversal:\n");
- print_lock_order = true;
+ if (lock_list == td->td_sleeplocks)
+ print_lock_order = true;
}
/*