aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKonstantin Belousov <kib@FreeBSD.org>2024-04-29 18:51:53 +0000
committerKonstantin Belousov <kib@FreeBSD.org>2024-05-03 00:25:33 +0000
commit66e0bf7668548f3bb98dfaf92938b7ebf953b5d2 (patch)
treeb8ddd8feaf398bcdd0401292c29cafc022739789
parenteadd4eae929bfc1c09a04a36612681b58e08926d (diff)
downloadsrc-66e0bf7668548f3bb98dfaf92938b7ebf953b5d2.tar.gz
src-66e0bf7668548f3bb98dfaf92938b7ebf953b5d2.zip
kcmp_pget(): add an assert that we did not hold the current process
(cherry picked from commit 1e01650a787028fd558e8cb709c232e335fc2cd9)
-rw-r--r--sys/kern/sys_generic.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/sys/kern/sys_generic.c b/sys/kern/sys_generic.c
index f3fd39079a82..dd845e653929 100644
--- a/sys/kern/sys_generic.c
+++ b/sys/kern/sys_generic.c
@@ -2094,11 +2094,15 @@ kcmp_cmp(uintptr_t a, uintptr_t b)
static int
kcmp_pget(struct thread *td, pid_t pid, struct proc **pp)
{
+ int error;
+
if (pid == td->td_proc->p_pid) {
*pp = td->td_proc;
return (0);
}
- return (pget(pid, PGET_CANDEBUG | PGET_NOTWEXIT | PGET_HOLD, pp));
+ error = pget(pid, PGET_CANDEBUG | PGET_NOTWEXIT | PGET_HOLD, pp);
+ MPASS(*pp != td->td_proc);
+ return (error);
}
int