diff options
| author | Ryan Libby <rlibby@FreeBSD.org> | 2025-10-15 04:01:48 +0000 |
|---|---|---|
| committer | Ryan Libby <rlibby@FreeBSD.org> | 2025-10-15 04:01:48 +0000 |
| commit | 68501a93076ac095be7a96ecd55d15287c497c9d (patch) | |
| tree | bf1767c55bd39677fc0ca2a6e9316a9186e9a7c3 | |
| parent | ead721935251ab5640ea736d4269814b7f9d2f64 (diff) | |
mv88e151x: fix potential attach and autonegotiation issues
Reported by: GCC -Wmaybe-uninitialized, -Wtautological-compare
Reviewed by: kp
Differential Revision: https://reviews.freebsd.org/D45919
| -rw-r--r-- | sys/dev/mii/mv88e151x.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/sys/dev/mii/mv88e151x.c b/sys/dev/mii/mv88e151x.c index 618ad81471c9..fb03b2a7a917 100644 --- a/sys/dev/mii/mv88e151x.c +++ b/sys/dev/mii/mv88e151x.c @@ -97,7 +97,7 @@ mv88e151x_attach(device_t dev) { const struct mii_attach_args *ma; struct mii_softc *sc; - uint32_t cop_cap, cop_extcap; + uint32_t cop_cap = 0, cop_extcap = 0; sc = device_get_softc(dev); ma = device_get_ivars(dev); @@ -224,10 +224,12 @@ mv88e151x_fiber_status(struct mii_softc *phy) else if (reg & MV88E151X_STATUS_LINK && reg & MV88E151X_STATUS_SYNC && (reg & MV88E151X_STATUS_ENERGY) == 0) { - if ((reg & MV88E151X_STATUS_SPEED_MASK) == + if (((reg & MV88E151X_STATUS_SPEED_MASK) >> + MV88E151X_STATUS_SPEED_SHIFT) == MV88E151X_STATUS_SPEED_1000) mii->mii_media_active |= IFM_1000_SX; - else if ((reg & MV88E151X_STATUS_SPEED_MASK) == + else if (((reg & MV88E151X_STATUS_SPEED_MASK) >> + MV88E151X_STATUS_SPEED_SHIFT) == MV88E151X_STATUS_SPEED_100) mii->mii_media_active |= IFM_100_FX; else |