aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristos Margiolis <christos@FreeBSD.org>2025-11-11 12:06:32 +0000
committerChristos Margiolis <christos@FreeBSD.org>2025-11-11 12:06:32 +0000
commit699fd108c50ccbd576476a2c95fa03e16492f2f9 (patch)
tree5f4a9193bbc3e8642a3dac53f4b21163b8175627
parent92dcd20222a2674ba31ae09865da19d948992994 (diff)
sound: Remove unnecessary initializations in feeder_create()
We do not need to zero out fields since the struct is allocated with M_ZERO. Also we no longer need to have a special case for the root feeder. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: markj Differential Revision: https://reviews.freebsd.org/D53558
-rw-r--r--sys/dev/sound/pcm/feeder.c11
1 files changed, 1 insertions, 10 deletions
diff --git a/sys/dev/sound/pcm/feeder.c b/sys/dev/sound/pcm/feeder.c
index 874148cd9ab0..75c0f0405040 100644
--- a/sys/dev/sound/pcm/feeder.c
+++ b/sys/dev/sound/pcm/feeder.c
@@ -88,19 +88,10 @@ feeder_create(struct feeder_class *fc, struct pcm_feederdesc *desc)
if (f == NULL)
return NULL;
- f->data = NULL;
- f->source = NULL;
- f->parent = NULL;
f->class = fc;
f->desc = &(f->desc_static);
-
- if (desc) {
+ if (desc != NULL)
*(f->desc) = *desc;
- } else {
- f->class->type = FEEDER_ROOT;
- f->desc->in = 0;
- f->desc->out = 0;
- }
err = FEEDER_INIT(f);
if (err) {