diff options
| author | Christos Margiolis <christos@FreeBSD.org> | 2026-01-12 11:27:15 +0000 |
|---|---|---|
| committer | Christos Margiolis <christos@FreeBSD.org> | 2026-01-12 11:27:15 +0000 |
| commit | 6b69d6726a7d3455fb295abfcf9aedd48c580d4a (patch) | |
| tree | 05c795f8d0239f97787f180745007ce7c36f3d48 | |
| parent | c5dc38bcc2916018566b3b6eb46bcbbc68adf01f (diff) | |
sound: Unlock around uiomove() in midi_{read,write}()
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
Reviewed by: markj
Differential Revision: https://reviews.freebsd.org/D54130
| -rw-r--r-- | sys/dev/sound/midi/midi.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/sys/dev/sound/midi/midi.c b/sys/dev/sound/midi/midi.c index c86f5fb41b14..8c38b00f15ad 100644 --- a/sys/dev/sound/midi/midi.c +++ b/sys/dev/sound/midi/midi.c @@ -391,9 +391,11 @@ midi_read(struct cdev *i_dev, struct uio *uio, int ioflag) used = MIN(used, MIDI_RSIZE); MIDIQ_DEQ(m->inq, buf, used); + mtx_unlock(&m->lock); retval = uiomove(buf, used, uio); if (retval) - goto err1; + goto err0; + mtx_lock(&m->lock); } /* @@ -457,9 +459,11 @@ midi_write(struct cdev *i_dev, struct uio *uio, int ioflag) used = MIN(MIDIQ_AVAIL(m->outq), uio->uio_resid); used = MIN(used, MIDI_WSIZE); + mtx_unlock(&m->lock); retval = uiomove(buf, used, uio); if (retval) - goto err1; + goto err0; + mtx_lock(&m->lock); MIDIQ_ENQ(m->outq, buf, used); /* * Inform the bottom half that data can be written |