diff options
| author | Konstantin Belousov <kib@FreeBSD.org> | 2022-01-09 05:09:22 +0000 |
|---|---|---|
| committer | Konstantin Belousov <kib@FreeBSD.org> | 2022-01-09 05:36:06 +0000 |
| commit | 6d06bc688eb5a9f9e389b69c388d591a40edc422 (patch) | |
| tree | 5276868df6f35f63cf5014c9969baceb239a7ee1 | |
| parent | e200809190fd8472fe525b2527ff1122b37999ac (diff) | |
| download | src-6d06bc688eb5a9f9e389b69c388d591a40edc422.tar.gz src-6d06bc688eb5a9f9e389b69c388d591a40edc422.zip | |
libc clnt_com_create: relock rpcsoc_lock earlier when port is obtained from portmapper
Otherwise on mapper failure we goto error handler which expect
rpscoc_lock owned, but we do not.
PR: 261051
Reported by: RyanCai <ryancaicse@gmail.com>
Sponsored by: The FreeBSD Foundation
MFC after: 1 week
| -rw-r--r-- | lib/libc/rpc/rpc_soc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/libc/rpc/rpc_soc.c b/lib/libc/rpc/rpc_soc.c index 1e5cd86d7ed4..ae23442e9a16 100644 --- a/lib/libc/rpc/rpc_soc.c +++ b/lib/libc/rpc/rpc_soc.c @@ -120,11 +120,11 @@ clnt_com_create(struct sockaddr_in *raddr, rpcprog_t prog, rpcvers_t vers, int * proto = strcmp(tp, "udp") == 0 ? IPPROTO_UDP : IPPROTO_TCP; sport = pmap_getport(raddr, (u_long)prog, (u_long)vers, proto); + mutex_lock(&rpcsoc_lock); /* pmap_getport is recursive */ if (sport == 0) { goto err; } raddr->sin_port = htons(sport); - mutex_lock(&rpcsoc_lock); /* pmap_getport is recursive */ } /* Transform sockaddr_in to netbuf */ |