aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKonstantin Belousov <kib@FreeBSD.org>2021-10-16 18:28:03 +0000
committerKonstantin Belousov <kib@FreeBSD.org>2021-10-26 02:26:27 +0000
commit84722e8171a0f5732eef9e817573000f93ea9bd8 (patch)
treea476d8e786f80f58eaf94b7ff84083c37affbad6
parenta89f144b0da250badd599e507977d8ee56e03d5b (diff)
sys_procctl(): zero the data buffer once, on syscall entry
(cherry picked from commit 32026f5983ed00e64829f8c20b09748077809729)
-rw-r--r--sys/kern/kern_procctl.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/sys/kern/kern_procctl.c b/sys/kern/kern_procctl.c
index 7a88ef24d987..387706a0cb1e 100644
--- a/sys/kern/kern_procctl.c
+++ b/sys/kern/kern_procctl.c
@@ -171,7 +171,6 @@ reap_status(struct thread *td, struct proc *p, void *data)
rs = data;
sx_assert(&proctree_lock, SX_LOCKED);
- bzero(rs, sizeof(*rs));
if ((p->p_treeflag & P_TREE_REAPER) == 0) {
reap = p->p_reaper;
} else {
@@ -850,6 +849,8 @@ sys_procctl(struct thread *td, struct procctl_args *uap)
if (uap->com == 0 || uap->com >= nitems(procctl_cmds_info))
return (EINVAL);
cmd_info = &procctl_cmds_info[uap->com];
+ bzero(&x, sizeof(x));
+
if (cmd_info->copyin_sz > 0) {
error = copyin(uap->data, &x, cmd_info->copyin_sz);
if (error != 0)