aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYuri Pankov <yuripv@FreeBSD.org>2021-04-11 22:02:12 +0000
committerYuri Pankov <yuripv@FreeBSD.org>2021-04-15 19:19:43 +0000
commit913a9cc33ea55538f2c3366016f79f4b2a79e3d0 (patch)
tree81eca65d99938c2a4c65e434865450c64807de73
parentf2e38602de89608b46a3b920fc222fdcf50864dd (diff)
downloadsrc-913a9cc33ea55538f2c3366016f79f4b2a79e3d0.tar.gz
src-913a9cc33ea55538f2c3366016f79f4b2a79e3d0.zip
setclassenvironment: trim leading spaces in variable names
Trim leading spaces in variable names when the list is e.g. pretty-formatted in /etc/login.conf or ~/.login_conf. PR: 247947 Reviewed by: allanjude Differential Revision: https://reviews.freebsd.org/D25649 (cherry picked from commit eeaf9d562fe137e0c52b8c346742dccfc8bde015)
-rw-r--r--lib/libutil/login_class.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/lib/libutil/login_class.c b/lib/libutil/login_class.c
index bd1ddff90111..4925c7a04664 100644
--- a/lib/libutil/login_class.c
+++ b/lib/libutil/login_class.c
@@ -232,12 +232,17 @@ setclassenvironment(login_cap_t *lc, const struct passwd * pwd, int paths)
while (*set_env != NULL) {
char *p = strchr(*set_env, '=');
- if (p != NULL) { /* Discard invalid entries */
+ if (p != NULL && p != *set_env) { /* Discard invalid entries */
+ const char *ep;
char *np;
*p++ = '\0';
+ /* Strip leading spaces from variable name */
+ ep = *set_env;
+ while (*ep == ' ' || *ep == '\t')
+ ep++;
if ((np = substvar(p, pwd, hlen, pch, nlen)) != NULL) {
- setenv(*set_env, np, 1);
+ setenv(ep, np, 1);
free(np);
}
}