diff options
author | Navdeep Parhar <np@FreeBSD.org> | 2022-03-07 19:17:05 +0000 |
---|---|---|
committer | Navdeep Parhar <np@FreeBSD.org> | 2022-03-07 20:05:48 +0000 |
commit | 9282f04ff0ee89cc4064e510f7fa505cfc890bf0 (patch) | |
tree | a0a43f9b365827b059b57f76409e766f95551d25 | |
parent | 0455cc7104ec8e8dd54b3f44049112a5a8ca329c (diff) | |
download | src-9282f04ff0ee89cc4064e510f7fa505cfc890bf0.tar.gz src-9282f04ff0ee89cc4064e510f7fa505cfc890bf0.zip |
cxgbe(4): dump_devlog should never fail silently.
Do the same thing as dump_cimla and log a warning on failure.
MFC after: 3 days
Sponsored by: Chelsio Communications
-rw-r--r-- | sys/dev/cxgbe/t4_main.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c index dafbdfede158..59da0acc6c86 100644 --- a/sys/dev/cxgbe/t4_main.c +++ b/sys/dev/cxgbe/t4_main.c @@ -9447,8 +9447,11 @@ dump_devlog(struct adapter *sc) int rc; struct sbuf sb; - if (sbuf_new(&sb, NULL, 4096, SBUF_AUTOEXTEND) != &sb) + if (sbuf_new(&sb, NULL, 4096, SBUF_AUTOEXTEND) != &sb) { + log(LOG_DEBUG, "%s: failed to generate devlog dump.\n", + device_get_nameunit(sc->dev)); return; + } rc = sbuf_devlog(sc, &sb, M_NOWAIT); if (rc == 0) { rc = sbuf_finish(&sb); |