aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Johnston <markj@FreeBSD.org>2020-01-07 16:07:30 +0000
committerMark Johnston <markj@FreeBSD.org>2020-01-07 16:07:30 +0000
commit958ff217e752365651e03dd4e605e6ea6aa19ba8 (patch)
treeac8ab3f3e3d807962d6947365b88daeed47780b7
parent68faee11e868d70f5f79e58eeb1d5bfcc112c471 (diff)
downloadsrc-958ff217e752365651e03dd4e605e6ea6aa19ba8.tar.gz
src-958ff217e752365651e03dd4e605e6ea6aa19ba8.zip
Decrease logging severity when adding a device or reading config table.
In PR 243056 a user reports some spam from smartpqi(4). In particular, the driver warns about an unrecognized PQI_CONF_TABLE_SECTION_SOFT_RESET section (not yet defined in the driver, but handled in Linux), but this doesn't cause any problems. The Linux driver also does not warn about unrecognized sections. Also do not log a warning when a device is added, since this is routine. Lower severity to DISC, to match pqisrc_remove_device(). PR: 243056 Reviewed by: sbruno MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D23023
Notes
Notes: svn path=/head/; revision=356445
-rw-r--r--sys/dev/smartpqi/smartpqi_discovery.c2
-rw-r--r--sys/dev/smartpqi/smartpqi_init.c2
2 files changed, 2 insertions, 2 deletions
diff --git a/sys/dev/smartpqi/smartpqi_discovery.c b/sys/dev/smartpqi/smartpqi_discovery.c
index 69e936bd9aab..c86b47cc07d1 100644
--- a/sys/dev/smartpqi/smartpqi_discovery.c
+++ b/sys/dev/smartpqi/smartpqi_discovery.c
@@ -1213,7 +1213,7 @@ static int pqisrc_add_device(pqisrc_softstate_t *softs,
pqi_scsi_dev_t *device)
{
DBG_FUNC("IN\n");
- DBG_WARN("vendor: %s model: %s bus:%d target:%d lun:%d is_physical_device:0x%x expose_device:0x%x volume_offline 0x%x volume_status 0x%x \n",
+ DBG_DISC("vendor: %s model: %s bus:%d target:%d lun:%d is_physical_device:0x%x expose_device:0x%x volume_offline 0x%x volume_status 0x%x \n",
device->vendor, device->model, device->bus, device->target, device->lun, device->is_physical_device, device->expose_device, device->volume_offline, device->volume_status);
device->invalid = false;
diff --git a/sys/dev/smartpqi/smartpqi_init.c b/sys/dev/smartpqi/smartpqi_init.c
index 9e57680a6fd7..e95a8d98cbb6 100644
--- a/sys/dev/smartpqi/smartpqi_init.c
+++ b/sys/dev/smartpqi/smartpqi_init.c
@@ -453,7 +453,7 @@ int pqisrc_process_config_table(pqisrc_softstate_t *softs)
ret = PQI_STATUS_SUCCESS;
break;
default:
- DBG_ERR("unrecognized PQI config table section ID: 0x%x\n",
+ DBG_INFO("unrecognized PQI config table section ID: 0x%x\n",
LE_16(section_hdr->section_id));
break;
}