diff options
| author | Rick Macklem <rmacklem@FreeBSD.org> | 2022-08-27 23:03:18 +0000 |
|---|---|---|
| committer | Rick Macklem <rmacklem@FreeBSD.org> | 2022-09-02 01:52:59 +0000 |
| commit | a6f3979ad1923b7e742a6b4464917c9baea5b058 (patch) | |
| tree | d5487c2a45d8062ea2645fc721806a226753aa1b | |
| parent | 108b6eb670ecced4674747fbec26c39fc8df0a55 (diff) | |
| download | src-a6f3979ad1923b7e742a6b4464917c9baea5b058.tar.gz src-a6f3979ad1923b7e742a6b4464917c9baea5b058.zip | |
nfscl: Fix handling of nd_slotid while handling NFSERR_BADSESSION
When the NFSv4.1/4.2 client is handling a server error
of NFSERR_BADSESSION, it retries RPCs with a new session.
Without this patch, the nd_slotid was not being updated
for the new session.
This would result in a bogus console message like
"Wrong session srvslot=X slot=Y" and then it would
free the incorrect slot, often generating a
"freeing free slot!!" console message as well.
This patch fixes the problem.
Note that FreeBSD NFSv4.1/4.2 servers only
generate a NFSERR_BADSESSION error after a reboot
or after a client does a DestroySession operation.
PR: 260011
(cherry picked from commit fb29f817586972444d65b1548287a51f27891639)
| -rw-r--r-- | sys/fs/nfs/nfs_commonkrpc.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/fs/nfs/nfs_commonkrpc.c b/sys/fs/nfs/nfs_commonkrpc.c index 150d92414e7a..81df586879c5 100644 --- a/sys/fs/nfs/nfs_commonkrpc.c +++ b/sys/fs/nfs/nfs_commonkrpc.c @@ -1169,6 +1169,8 @@ tryagain: *tl++ = txdr_unsigned(slotseq); *tl++ = txdr_unsigned(slotpos); *tl = txdr_unsigned(maxslot); + nd->nd_slotid = slotpos; + nd->nd_flag |= ND_HASSLOTID; } if (reterr == NFSERR_BADSESSION || reterr == 0) { |