aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Johnston <markj@FreeBSD.org>2026-04-27 20:56:21 +0000
committerMark Johnston <markj@FreeBSD.org>2026-04-29 14:45:04 +0000
commita813012f4b76444dfde03146487042133c657884 (patch)
treeb41df55f30def02e7275b39a4c81cb5efaf14957
parentb3087e05e848405c3b9c8577a86fed173f3a8a42 (diff)
dhclient: Fix reallocation of dhclient script environments
When the number of DHCP options exceeds a threshold, script_set_env() will reallocate the environment, stored as an array of pointers. The calculation of the array size failed to multiply by the pointer size, resulting in a smaller than expected buffer which admits out-of-bounds writes. Approved by: so Security: FreeBSD-SA-26:15.dhclient Security: CVE-2026-42511 Reported by: Joshua Rogers of AISLE Research Team (https://aisle.com/)
-rw-r--r--sbin/dhclient/dhclient.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sbin/dhclient/dhclient.c b/sbin/dhclient/dhclient.c
index 01ef38530cdf..c7a7fcca06ff 100644
--- a/sbin/dhclient/dhclient.c
+++ b/sbin/dhclient/dhclient.c
@@ -2438,8 +2438,8 @@ script_set_env(struct client_state *client, const char *prefix,
char **newscriptEnv;
int newscriptEnvsize = client->scriptEnvsize + 50;
- newscriptEnv = realloc(client->scriptEnv,
- newscriptEnvsize);
+ newscriptEnv = reallocarray(client->scriptEnv,
+ newscriptEnvsize, sizeof(char *));
if (newscriptEnv == NULL) {
free(client->scriptEnv);
client->scriptEnv = NULL;