diff options
| author | Mark Johnston <markj@FreeBSD.org> | 2021-06-16 13:46:56 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2021-06-16 13:46:56 +0000 |
| commit | bc6a2267fffeafd3946637607a74cfd639398f9d (patch) | |
| tree | 195ab7253c7e123b1b49289931734f806fe39836 | |
| parent | a397b5508320e757274bc652b43ccb2e1a702933 (diff) | |
| download | src-bc6a2267fffeafd3946637607a74cfd639398f9d.tar.gz src-bc6a2267fffeafd3946637607a74cfd639398f9d.zip | |
ipfw: Update the pfil mbuf pointer in ipfw_check_frame()
ipfw_chk() might call m_pullup() and thus can change the mbuf chain
head. In this case, the new chain head has to be returned to the pfil
hook caller, otherwise the pfil hook caller is left with a dangling
pointer.
Note that this affects only the link-layer hooks installed when the
net.link.ether.ipfw sysctl is set to 1.
PR: 256439, 254015, 255069, 255104
Fixes: f355cb3e6
Reviewed by: ae
MFC after: 3 days
Sponsored by: The FreeBSD Foundation
Differential Revision: https://reviews.freebsd.org/D30764
| -rw-r--r-- | sys/netpfil/ipfw/ip_fw_pfil.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sys/netpfil/ipfw/ip_fw_pfil.c b/sys/netpfil/ipfw/ip_fw_pfil.c index e21831c80ec6..01a44df47180 100644 --- a/sys/netpfil/ipfw/ip_fw_pfil.c +++ b/sys/netpfil/ipfw/ip_fw_pfil.c @@ -371,6 +371,8 @@ again: } ipfw = ipfw_chk(&args); + if (!mem) + *p.m = args.m; ret = PFIL_PASS; switch (ipfw) { |