aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMark Johnston <markj@FreeBSD.org>2022-02-25 18:42:51 +0000
committerMark Johnston <markj@FreeBSD.org>2022-02-25 18:55:24 +0000
commitc84bb8cd771ce4bed58152e47a32dda470bef23a (patch)
treebd6df7f782222de9fcd72b699d22272d500a1535
parent1517b8d5a7f58897200497811de1b18809c07d3e (diff)
downloadsrc-c84bb8cd771ce4bed58152e47a32dda470bef23a.tar.gz
src-c84bb8cd771ce4bed58152e47a32dda470bef23a.zip
rmlock: Micro-optimize read locking
Use get_pcpu() instead of an open-coded pcpu_find(td->td_oncpu). This eliminates some memory accesses and results in a shorter instruction sequence. Note that get_pcpu() didn't exist when rmlocks were added. Reviewed by: jah, mjg MFC after: 1 week Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D34377
-rw-r--r--sys/kern/kern_rmlock.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/kern/kern_rmlock.c b/sys/kern/kern_rmlock.c
index 08a01fca9827..bbea8041360a 100644
--- a/sys/kern/kern_rmlock.c
+++ b/sys/kern/kern_rmlock.c
@@ -452,7 +452,7 @@ _rm_rlock(struct rmlock *rm, struct rm_priotracker *tracker, int trylock)
atomic_interrupt_fence();
- pc = cpuid_to_pcpu[td->td_oncpu]; /* pcpu_find(td->td_oncpu); */
+ pc = get_pcpu();
rm_tracker_add(pc, tracker);
@@ -517,7 +517,7 @@ _rm_runlock(struct rmlock *rm, struct rm_priotracker *tracker)
return;
td->td_critnest++; /* critical_enter(); */
- pc = cpuid_to_pcpu[td->td_oncpu]; /* pcpu_find(td->td_oncpu); */
+ pc = get_pcpu();
rm_tracker_remove(pc, tracker);
td->td_critnest--;
sched_unpin();