diff options
| author | Gleb Smirnoff <glebius@FreeBSD.org> | 2025-01-11 05:08:02 +0000 |
|---|---|---|
| committer | Ed Maste <emaste@FreeBSD.org> | 2025-01-20 14:28:54 +0000 |
| commit | d6fbd34acbbc90ae106fc1fa08d83d5f25d59039 (patch) | |
| tree | ee38adb9ae6c36a2201b6e3e11c041de86258ce5 | |
| parent | eeecaa064c8d4ba0f4a17739527ef285ee56fd36 (diff) | |
libbsnmptools: avoid uninitialized snmptoolctx->passwd with empty password
The removed check left snmptoolctx->passwd pointer to uninitialized
memory. Always calling strlcpy(3) would guarantee that with empty
password it will point to empty string.
Submitted by: markj
PR: 283909
(cherry picked from commit 3999a860d6e899de98b1025317d2d0ef1f83255f)
(cherry picked from commit 0bfbd30663b68a851ebf24667d121c6891c86827)
| -rw-r--r-- | usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c b/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c index 373e91de06d3..e1339877e945 100644 --- a/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c +++ b/usr.sbin/bsnmpd/tools/libbsnmptools/bsnmptools.c @@ -178,8 +178,7 @@ snmptool_init(struct snmp_toolinfo *snmptoolctx) warn("malloc() failed"); return (-1); } - if (slen > 0) - strlcpy(snmptoolctx->passwd, str, slen + 1); + strlcpy(snmptoolctx->passwd, str, slen + 1); } return (0); |