diff options
| author | Aaron LI <aly@aaronly.me> | 2023-11-11 13:13:08 +0000 |
|---|---|---|
| committer | Kristof Provost <kp@FreeBSD.org> | 2023-11-11 13:13:08 +0000 |
| commit | dcc4d2939f789a6d1f272ffeab2068ba2b7525ea (patch) | |
| tree | a5e795e7734f55efea35eddb8de1c6bd6890c4da | |
| parent | 4b2d944b406e89d9d07e4142c66f635a25b245bb (diff) | |
| download | src-dcc4d2939f789a6d1f272ffeab2068ba2b7525ea.tar.gz src-dcc4d2939f789a6d1f272ffeab2068ba2b7525ea.zip | |
if_wg: Missing radix unlock can cause deadlock
In function 'wg_aip_add()', the error path of returning ENOMEM when
(node == NULL) is forgetting to unlock the radix tree, and thus may lead
to a deadlock.
PR: 275001
Reviewed by: kp
MFC after: 1 week
| -rw-r--r-- | sys/dev/wg/if_wg.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/dev/wg/if_wg.c b/sys/dev/wg/if_wg.c index 4a21afe82eb5..0ea40b763416 100644 --- a/sys/dev/wg/if_wg.c +++ b/sys/dev/wg/if_wg.c @@ -562,7 +562,7 @@ wg_aip_add(struct wg_softc *sc, struct wg_peer *peer, sa_family_t af, const void node = root->rnh_lookup(&aip->a_addr, &aip->a_mask, &root->rh); if (!node) { free(aip, M_WG); - return (ENOMEM); + ret = ENOMEM; } else if (node != aip->a_nodes) { free(aip, M_WG); aip = (struct wg_aip *)node; |