aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorHaoxiang Li <lihaoxiang@isrc.iscas.ac.cn>2026-05-26 13:21:39 +0000
committerKonstantin Belousov <kib@FreeBSD.org>2026-05-27 08:09:31 +0000
commitf0e702a7a289f0f350bdaeb943805d6d17f9e403 (patch)
treee2f0980a5789da9de9a4bbd2fb5e3567cebb5a56
parentf1de8e3511d043e707cf4a63ea76a15a42f81ab0 (diff)
smbfs: plug smbfs_node_alloc() leak of name buffers when insmntque() fails
PR: 295577 MFC after: 2 weeks
-rw-r--r--sys/fs/smbfs/smbfs_node.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/sys/fs/smbfs/smbfs_node.c b/sys/fs/smbfs/smbfs_node.c
index 9893987f7ccd..b2b5d63e2eaf 100644
--- a/sys/fs/smbfs/smbfs_node.c
+++ b/sys/fs/smbfs/smbfs_node.c
@@ -212,6 +212,10 @@ smbfs_node_alloc(struct mount *mp, struct vnode *dvp, const char *dirnm,
SMBERROR("new vnode '%s' born without parent ?\n", np->n_name);
error = insmntque(vp, mp);
if (error) {
+ smbfs_name_free(np->n_name);
+ free(np->n_rpath, M_SMBNODENAME);
+ if (np->n_parent != NULL && (np->n_flag & NREFPARENT) != 0)
+ vrele(np->n_parent);
free(np, M_SMBNODE);
return (error);
}