diff options
| author | Alex Richardson <arichardson@FreeBSD.org> | 2021-01-29 09:28:40 +0000 |
|---|---|---|
| committer | Dimitry Andric <dim@FreeBSD.org> | 2021-02-12 20:50:28 +0000 |
| commit | f2a88e744701de1b37d7463828f2147f96e39d58 (patch) | |
| tree | 0db8207a810f40d7f82c2033f8377ed38ce08ba2 | |
| parent | 9525ccc84e337f4261425fc8fbf9f0de18500a1b (diff) | |
| download | src-f2a88e744701de1b37d7463828f2147f96e39d58.tar.gz src-f2a88e744701de1b37d7463828f2147f96e39d58.zip | |
test_inf_inputs: Use atf_tc_expect_fail() instead of atf_tc_skip()
Reviewed By: lwhsu
Differential Revision: https://reviews.freebsd.org/D28396
(cherry picked from commit 4d2edf3af1dbd8a3e7cf1b22343a1ecfc2dd41ba)
Fix lib/msun's ctrig_test/test_inf_inputs test case with clang >= 10
This sprinkles a few strategic volatiles in an attempt to defeat clang's
optimization interfering with the expected floating-point exception
flags.
Reported by: lwhsu
PR: 244732
(cherry picked from commit ac76bc1145dd7f4476e5d982ce8f355f71015713)
| -rw-r--r-- | lib/msun/src/s_ccoshf.c | 2 | ||||
| -rw-r--r-- | lib/msun/src/s_ctanh.c | 2 | ||||
| -rw-r--r-- | lib/msun/src/s_ctanhf.c | 2 | ||||
| -rw-r--r-- | lib/msun/tests/ctrig_test.c | 3 |
4 files changed, 3 insertions, 6 deletions
diff --git a/lib/msun/src/s_ccoshf.c b/lib/msun/src/s_ccoshf.c index 5d7a09ba5f8d..e72395c277d5 100644 --- a/lib/msun/src/s_ccoshf.c +++ b/lib/msun/src/s_ccoshf.c @@ -43,7 +43,7 @@ static const float huge = 0x1p127; float complex ccoshf(float complex z) { - float x, y, h; + volatile float x, y, h; int32_t hx, hy, ix, iy; x = crealf(z); diff --git a/lib/msun/src/s_ctanh.c b/lib/msun/src/s_ctanh.c index 88afeb50e26e..13eb9d40b678 100644 --- a/lib/msun/src/s_ctanh.c +++ b/lib/msun/src/s_ctanh.c @@ -76,7 +76,7 @@ __FBSDID("$FreeBSD$"); double complex ctanh(double complex z) { - double x, y; + volatile double x, y; double t, beta, s, rho, denom; uint32_t hx, ix, lx; diff --git a/lib/msun/src/s_ctanhf.c b/lib/msun/src/s_ctanhf.c index d2bd0b6786f0..7d375eafd2ae 100644 --- a/lib/msun/src/s_ctanhf.c +++ b/lib/msun/src/s_ctanhf.c @@ -41,7 +41,7 @@ __FBSDID("$FreeBSD$"); float complex ctanhf(float complex z) { - float x, y; + volatile float x, y; float t, beta, s, rho, denom; uint32_t hx, ix; diff --git a/lib/msun/tests/ctrig_test.c b/lib/msun/tests/ctrig_test.c index b47ad43fa199..45b2b78b0416 100644 --- a/lib/msun/tests/ctrig_test.c +++ b/lib/msun/tests/ctrig_test.c @@ -248,9 +248,6 @@ ATF_TC_BODY(test_inf_inputs, tc) long double complex z, c, s; unsigned i; - if (atf_tc_get_config_var_as_bool_wd(tc, "ci", false)) - atf_tc_skip("https://bugs.freebsd.org/244732"); - /* * IN CSINH CCOSH CTANH * Inf,Inf +-Inf,NaN inval +-Inf,NaN inval 1,+-0 |