MAC/do: parse_rule_element(): Bug in parsing the origin ID

The ID field was allowed to be empty, which would be then parsed as 0 by
strtol().  There remains bugs in this function, where parsing for from-
or to- IDs accepts spaces and produces 0, but this will conveniently be
fixed in a later commit introducing strtoui_strict().

Reviewed by:    bapt
Approved by:    markj (mentor)
Sponsored by:   The FreeBSD Foundation
Differential Revision:  https://reviews.freebsd.org/D47612

1 files changed, 1 insertions, 1 deletions

diff --git a/sys/security/mac_do/mac_do.c b/sys/security/mac_do/mac_do.c
index 4ef9b68bf513..edd728ea070a 100644
--- a/sys/security/mac_do/mac_do.c
+++ b/sys/security/mac_do/mac_do.c
@@ -105,7 +105,7 @@ parse_rule_element(char *element, struct rule **rule)
 	}
 
 	id = strsep(&element, ":");
-	if (id == NULL) {
+	if (id == NULL || *id == '\0') {
 		error = EINVAL;
 		goto error;
 	}