aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLutz Donnerhacke <donner@FreeBSD.org>2021-05-15 09:32:57 +0000
committerLutz Donnerhacke <donner@FreeBSD.org>2021-05-23 12:55:20 +0000
commitfa670efa25ad960e17a6a9cb4601e5c3f19de5da (patch)
tree2742368bc6533504c94f0c1bab60dd95a8a4de70
parent3dc9f92a0d3dbe0d56201d8806cd9e93e4676cc4 (diff)
downloadsrc-fa670efa25ad960e17a6a9cb4601e5c3f19de5da.tar.gz
src-fa670efa25ad960e17a6a9cb4601e5c3f19de5da.zip
netgraph/ng_checksum: Fix double free error
m_pullup(9) frees the mbuf(9) chain in the case of an allocation error. The mbuf chain must not be freed again in this case. PR: 255874 Submitted by: <lylgood@foxmail.com> Approved by: markj Differential Revision: https://reviews.freebsd.org/D30273 (cherry picked from commit 687e510e5ce32fddf46a9dc1d517ccc8a8e25581)
-rw-r--r--sys/netgraph/ng_checksum.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/netgraph/ng_checksum.c b/sys/netgraph/ng_checksum.c
index 682375c805da..3b542bd86acc 100644
--- a/sys/netgraph/ng_checksum.c
+++ b/sys/netgraph/ng_checksum.c
@@ -682,9 +682,9 @@ bypass:
return (error);
done:
+ NG_FREE_M(m);
drop:
NG_FREE_ITEM(item);
- NG_FREE_M(m);
priv->stats.dropped++;