diff options
| author | Konstantin Belousov <kib@FreeBSD.org> | 2026-05-03 19:09:15 +0000 |
|---|---|---|
| committer | Konstantin Belousov <kib@FreeBSD.org> | 2026-05-03 19:58:36 +0000 |
| commit | fbecfc4aa028964f972a0457809aa041d415f61b (patch) | |
| tree | 91fcb6478b9b7dd0614770d777c4d006c775cb60 | |
| parent | b89155be25a7f501980a165e225b28abd886c1e5 (diff) | |
fdescfs: do not change vnode type on VOP_GETATTR()
There is no point to do it. The VNON type is good enough for fdescfs
operations, and changing the type on stat(2) is arbitrary and does not
serve much purpose, because we recalculate the returned file type on
each stat(2) anyway.
But setting the type to VLNK has undesired consequence of namei()
trying VOP_READLINK() there, which might fail since it defer the
calculation of path to vn_fullpath().
Submitted by: Mike <mmpestorich@gmail.com>
PR: 294768
MFC after: 2 weeks
| -rw-r--r-- | sys/fs/fdescfs/fdesc_vnops.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sys/fs/fdescfs/fdesc_vnops.c b/sys/fs/fdescfs/fdesc_vnops.c index c1188c3819e7..267e80918d1b 100644 --- a/sys/fs/fdescfs/fdesc_vnops.c +++ b/sys/fs/fdescfs/fdesc_vnops.c @@ -469,7 +469,6 @@ fdesc_getattr(struct vop_getattr_args *ap) break; } - vp->v_type = vap->va_type; return (0); } |