diff options
| author | Warner Losh <imp@FreeBSD.org> | 2026-02-02 13:30:22 +0000 |
|---|---|---|
| committer | Warner Losh <imp@FreeBSD.org> | 2026-02-02 13:31:21 +0000 |
| commit | ff9fe85ff245bfbf6f54f98175282be5cf500cb3 (patch) | |
| tree | 9d16be574127b5acfd35f2af321a980eb6d619b4 | |
| parent | 05322eec86ae42a8f873ba10d8da61bd61b5b48f (diff) | |
nvmecontrol: telemetry-log don't sanity check host generation number
Don't sanity check the host initiated generation number. It's not
necessarily constant between the two log page fetches. nvme-cli doesn't
do this stanity check and it generates a lot of false positives.
Sponsored by: Netflix
Differential Revision: https://reviews.freebsd.org/D55018
| -rw-r--r-- | sbin/nvmecontrol/telemetry.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/sbin/nvmecontrol/telemetry.c b/sbin/nvmecontrol/telemetry.c index bfa1325974d5..c22d53ecdfed 100644 --- a/sbin/nvmecontrol/telemetry.c +++ b/sbin/nvmecontrol/telemetry.c @@ -160,16 +160,6 @@ telemetry_log(const struct cmd *f, int argc, char *argv[]) chunk = size; read_logpage(fd, NVME_LOG_TELEMETRY_HOST_INITIATED, nsid, 0, 0, true, off, 0, 0, 0, &buf, chunk); - if (off == 0) { - /* - * Sanity check to make sure that the generation number - * didn't change between the two reads. - */ - if (tlp.hi_gen != buf.hi_gen) - warnx( - "Generation number changed from %d to %d", - tlp.hi_gen, buf.hi_gen); - } if (write(fdout, &buf, chunk) != chunk) err(EX_IOERR, "Error writing %s", opt.outfn); off += chunk; |