aboutsummaryrefslogtreecommitdiff
path: root/lib/liblua
diff options
context:
space:
mode:
authorMark Johnston <markj@FreeBSD.org>2021-09-17 14:44:23 +0000
committerMark Johnston <markj@FreeBSD.org>2021-09-17 14:47:46 +0000
commit7eb138a9e53636366e615bdf04062fedc044bcea (patch)
tree6f8ef433bbd78789fbda903f8c1f9ba714006530 /lib/liblua
parentdeef4b8ce8ba7292fe5088bf9f6d4e2e35662fe8 (diff)
downloadsrc-7eb138a9e53636366e615bdf04062fedc044bcea.tar.gz
src-7eb138a9e53636366e615bdf04062fedc044bcea.zip
libc/locale: Fix races between localeconv(3) and setlocale(3)
Each locale embeds a lazily initialized lconv which is populated by localeconv(3) and localeconv_l(3). When setlocale(3) updates the global locale, the lconv needs to be (lazily) reinitialized. To signal this, we set flag variables in the locale structure. There are two problems: - The flags are set before the locale is fully updated, so a concurrent localeconv() call can observe partially initialized locale data. - No barriers ensure that localeconv() observes a fully initialized locale if a flag is set. So, move the flag update appropriately, and use acq/rel barriers to provide some synchronization. Note that this is inadequate in the face of multiple concurrent calls to setlocale(3), but this is not expected to work regardless. Thanks to Henry Hu <henry.hu.sh@gmail.com> for providing a test case demonstrating the race. PR: 258360 MFC after: 3 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D31899
Diffstat (limited to 'lib/liblua')
0 files changed, 0 insertions, 0 deletions