aboutsummaryrefslogtreecommitdiff
path: root/sbin/ipf/ippool
diff options
context:
space:
mode:
authorBryan Drewery <bdrewery@FreeBSD.org>2014-08-19 15:04:32 +0000
committerBryan Drewery <bdrewery@FreeBSD.org>2014-08-19 15:04:32 +0000
commit5608fd23c27fa1e8ee595d7b678cbfd35d657fbe (patch)
treef5585fe1edc0507d12a8ac9729befa9b67327239 /sbin/ipf/ippool
parent7e1c22c4764b44758d6a65bad9fc5c6c108737d0 (diff)
downloadsrc-5608fd23c27fa1e8ee595d7b678cbfd35d657fbe.tar.gz
src-5608fd23c27fa1e8ee595d7b678cbfd35d657fbe.zip
Revert r267233 for now. PIE support needs to be reworked.
1. 50+% of NO_PIE use is fixed by adding -fPIC to INTERNALLIB and other build-only utility libraries. 2. Another 40% is fixed by generating _pic.a variants of various libraries. 3. Some of the NO_PIE use is a bit absurd as it is disabling PIE (and ASLR) where it never would work anyhow, such as csu or loader. This suggests there may be better ways of adding support to the tree. Many of these cases can be fixed such that -fPIE will work but there is really no reason to have it in those cases. 4. Some of the uses are working around hacks done to some Makefiles that are really building libraries but have been using bsd.prog.mk because the code is cleaner. Had they been using bsd.lib.mk then NO_PIE would not have been needed. We likely do want to enable PIE by default (opt-out) for non-tree consumers (such as ports). For in-tree though we probably want to only enable PIE (opt-in) for common attack targets such as remote service daemons and setuid utilities. This is also a great performance compromise since ASLR is expected to reduce performance. As such it does not make sense to enable it in all utilities such as ls(1) that have little benefit to having it enabled. Reported by: kib
Notes
Notes: svn path=/head/; revision=270168
Diffstat (limited to 'sbin/ipf/ippool')
-rw-r--r--sbin/ipf/ippool/Makefile2
1 files changed, 0 insertions, 2 deletions
diff --git a/sbin/ipf/ippool/Makefile b/sbin/ipf/ippool/Makefile
index bb7e9ceb24b9..6e3f85da847d 100644
--- a/sbin/ipf/ippool/Makefile
+++ b/sbin/ipf/ippool/Makefile
@@ -10,8 +10,6 @@ DPSRCS+= ${GENHDRS}
CLEANFILES+= ${GENHDRS} ippool_y.c ippool_l.c
-NO_PIE= yes
-
ippool_y.c: ippool_y.y
${YACC} -d ${.ALLSRC}
sed -e 's/yy/ippool_yy/g' \