path: root/sbin/mdconfig/tests
diff options
authorYan Ka Chiu <nyan@myuji.xyz>2022-05-22 16:33:02 +0000
committerKa Ho Ng <khng@FreeBSD.org>2022-05-22 16:36:48 +0000
commitb75e0eed345d2ab047a6b1b00a9a7c3bf92e992c (patch)
tree4b18cb366a7c84ced083520893d4014303e49990 /sbin/mdconfig/tests
parent298663855015c1eba7ccf5b88168f433653eb609 (diff)
pam_exec: fix segfault when authtok is null
According to pam_exec(8), the `expose_authtok` option should be ignored when the service function is `pam_sm_setcred`. Currently `pam_exec` only prevent prompt for anth token when `expose_authtok` is set on `pam_sm_setcred`. This subsequently led to segfault when there isn't an existing auth token available. Bug reported on this: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263893 After reading https://reviews.freebsd.org/rS349556 I am not sure if the default behaviour supposed to be simply not prompt for authentication token, or is it to ignore the option entirely as stated in the man page. This patch is therefore only adding an additional NULL check on the item `pam_get_item` provide, and exit with `PAM_SYSTEM_ERR` when such item is NULL. MFC after: 1 week Reviewed by: des, khng Differential Revision: https://reviews.freebsd.org/D35169
Diffstat (limited to 'sbin/mdconfig/tests')
0 files changed, 0 insertions, 0 deletions