path: root/stand/efi/loader/arch/i386
diff options
authorSimon J. Gerraty <sjg@FreeBSD.org>2020-03-08 17:42:42 +0000
committerSimon J. Gerraty <sjg@FreeBSD.org>2020-03-08 17:42:42 +0000
commitafc571b1a6fb341b0e3f603d4f3a2538093e91f5 (patch)
treea446172ecf9eb86977386f59f06ecfdd1bc7b1b2 /stand/efi/loader/arch/i386
parent601ee53858f61e7a130dc2e306202b5297626d25 (diff)
veloader use vectx API for kernel and modules
The vectx API, computes the hash for verifying a file as it is read. This avoids the overhead of reading files twice - once to verify, then again to load. For doing an install via loader, avoiding the need to rewind large files is critical. This API is only used for modules, kernel and mdimage as these are the biggest files read by the loader. The reduction in boot time depends on how expensive the I/O is on any given platform. On a fast VM we see 6% improvement. For install via loader the first file to be verified is likely to be the kernel, so some of the prep work (finding manifest etc) done by verify_file() needs to be factored so it can be reused for vectx_open(). For missing or unrecognized fingerprint entries, we fail in vectx_open() unless verifying is disabled. Otherwise fingerprint check happens in vectx_close() and since this API is only used for files which must be verified (VE_MUST) we panic if we get an incorrect hash. Reviewed by: imp,tsoome MFC after: 1 week Sponsored by: Juniper Networks Differential Revision: https://reviews.freebsd.org//D23827
Notes: svn path=/head/; revision=358744
Diffstat (limited to 'stand/efi/loader/arch/i386')
1 files changed, 2 insertions, 3 deletions
diff --git a/stand/efi/loader/arch/i386/i386_copy.c b/stand/efi/loader/arch/i386/i386_copy.c
index 522913f5da43..2c4b0deb49cf 100644
--- a/stand/efi/loader/arch/i386/i386_copy.c
+++ b/stand/efi/loader/arch/i386/i386_copy.c
@@ -51,9 +51,8 @@ i386_copyout(const vm_offset_t src, void *dest, const size_t len)
-i386_readin(const int fd, vm_offset_t dest, const size_t len)
+i386_readin(readin_handle_t fd, vm_offset_t dest, const size_t len)
- return (read(fd, PTOV(dest), len));
+ return (VECTX_READ(fd, PTOV(dest), len));