path: root/sys/cam/ctl/ctl_tpc.c
diff options
authorAlexander Motin <mav@FreeBSD.org>2021-02-19 03:07:32 +0000
committerAlexander Motin <mav@FreeBSD.org>2021-02-19 03:29:38 +0000
commit812c9f48a2b7bccc31b2a6077b299822357832e4 (patch)
tree010235d080cc84effb1ee127a2b3dfd3f7f21e66 /sys/cam/ctl/ctl_tpc.c
parent4621c4f2fd179eff0923140da9af122c42dbe78b (diff)
Save context switch per I/O for iSCSI and IOCTL frontends.
Introduce new CTL core KPI ctl_run(), preprocessing I/Os in the caller context instead of scheduling another thread just for that. This call may sleep, that is not acceptable for some frontends like the original CAM/FC one, but iSCSI already has separate sleepable per-connection RX threads, and another thread scheduling is mostly just a waste of time. IOCTL frontend actually waits for the I/O completion in the caller thread, so the use of another thread for this has even less sense. With this change I can measure ~5% IOPS improvement on 4KB iSCSI I/Os to ZFS. MFC after: 1 month
Diffstat (limited to 'sys/cam/ctl/ctl_tpc.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/sys/cam/ctl/ctl_tpc.c b/sys/cam/ctl/ctl_tpc.c
index 456157749c89..5e6cb09760a7 100644
--- a/sys/cam/ctl/ctl_tpc.c
+++ b/sys/cam/ctl/ctl_tpc.c
@@ -1628,7 +1628,7 @@ tpc_done(union ctl_io *io)
io->io_hdr.flags &= ~CTL_FLAG_ABORT;
io->io_hdr.flags &= ~CTL_FLAG_SENT_2OTHER_SC;
if (tpcl_queue(io, tio->lun) != CTL_RETVAL_COMPLETE) {
- printf("%s: error returned from ctl_queue()!\n",
+ printf("%s: error returned from tpcl_queue()!\n",
io->io_hdr.status = old_status;
} else