aboutsummaryrefslogtreecommitdiff
path: root/sys/netsmb
diff options
context:
space:
mode:
authorEd Schouten <ed@FreeBSD.org>2008-09-27 08:51:18 +0000
committerEd Schouten <ed@FreeBSD.org>2008-09-27 08:51:18 +0000
commit6bfa9a2d66dd0e00182017d6741d44e54d0b2cca (patch)
treedd0035910760a440d495b23940f57a42ed24ca85 /sys/netsmb
parent45cfb1dc538113eab50616b88da908b1bb728561 (diff)
downloadsrc-6bfa9a2d66dd0e00182017d6741d44e54d0b2cca.tar.gz
src-6bfa9a2d66dd0e00182017d6741d44e54d0b2cca.zip
Replace all calls to minor() with dev2unit().
After I removed all the unit2minor()/minor2unit() calls from the kernel yesterday, I realised calling minor() everywhere is quite confusing. Character devices now only have the ability to store a unit number, not a minor number. Remove the confusion by using dev2unit() everywhere. This commit could also be considered as a bug fix. A lot of drivers call minor(), while they should actually be calling dev2unit(). In -CURRENT this isn't a problem, but it turns out we never had any problem reports related to that issue in the past. I suspect not many people connect more than 256 pieces of the same hardware. Reviewed by: kib
Notes
Notes: svn path=/head/; revision=183397
Diffstat (limited to 'sys/netsmb')
-rw-r--r--sys/netsmb/smb_dev.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/sys/netsmb/smb_dev.c b/sys/netsmb/smb_dev.c
index c77297eec409..50cc64420235 100644
--- a/sys/netsmb/smb_dev.c
+++ b/sys/netsmb/smb_dev.c
@@ -132,8 +132,8 @@ nsmb_dev_open(struct cdev *dev, int oflags, int devtype, struct thread *td)
* someone should take care of it.
*/
if ((dev->si_flags & SI_NAMED) == 0)
- make_dev(&nsmb_cdevsw, minor(dev), cred->cr_uid, cred->cr_gid, 0700,
- NSMB_NAME"%d", dev2unit(dev));
+ make_dev(&nsmb_cdevsw, dev2unit(dev), cred->cr_uid,
+ cred->cr_gid, 0700, NSMB_NAME"%d", dev2unit(dev));
bzero(sdp, sizeof(*sdp));
/*
STAILQ_INIT(&sdp->sd_rqlist);