aboutsummaryrefslogtreecommitdiff
path: root/sys
diff options
context:
space:
mode:
authorKonstantin Belousov <kib@FreeBSD.org>2021-01-30 19:18:22 +0000
committerKonstantin Belousov <kib@FreeBSD.org>2021-02-12 01:02:21 +0000
commit013168db8cea926c3dde1247d400d6bedf9a889d (patch)
treec22f6a0a2f68622feb75d0b585a6c8c877f2a139 /sys
parentb59a8e63d6bf9092419b7a421c655d0ae2099662 (diff)
downloadsrc-013168db8cea926c3dde1247d400d6bedf9a889d.tar.gz
src-013168db8cea926c3dde1247d400d6bedf9a889d.zip
ufs_inactive(): stop hiding ERELOOKUP from ffs_truncate(), return it.
VFS should retry inactivation when possible, then. This should provide timely removal of unlinked unreferenced inodes. Reviewed by: chs, mckusick Tested by: pho MFC after: 2 weeks Sponsored by: The FreeBSD Foundation
Diffstat (limited to 'sys')
-rw-r--r--sys/ufs/ffs/ffs_softdep.c9
-rw-r--r--sys/ufs/ufs/ufs_inode.c2
2 files changed, 5 insertions, 6 deletions
diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c
index 3cc76f9142c3..8c3ae9dd95fc 100644
--- a/sys/ufs/ffs/ffs_softdep.c
+++ b/sys/ufs/ffs/ffs_softdep.c
@@ -1493,13 +1493,14 @@ get_parent_vp(struct vnode *vp, struct mount *mp, ino_t inum, struct buf *bp,
}
/*
- * Do not drop vnode lock while inactivating. This
- * would result in leaks of the VI flags and
- * reclaiming of non-truncated vnode. Instead,
+ * Do not drop vnode lock while inactivating during
+ * vunref. This would result in leaks of the VI flags
+ * and reclaiming of non-truncated vnode. Instead,
* re-schedule inactivation hoping that we would be
* able to sync inode later.
*/
- if ((vp->v_iflag & VI_DOINGINACT) != 0) {
+ if ((vp->v_iflag & VI_DOINGINACT) != 0 &&
+ (vp->v_vflag & VV_UNREF) != 0) {
VI_LOCK(vp);
vp->v_iflag |= VI_OWEINACT;
VI_UNLOCK(vp);
diff --git a/sys/ufs/ufs/ufs_inode.c b/sys/ufs/ufs/ufs_inode.c
index 15bd8be448a9..46e4f8e54e41 100644
--- a/sys/ufs/ufs/ufs_inode.c
+++ b/sys/ufs/ufs/ufs_inode.c
@@ -212,8 +212,6 @@ out:
vrecycle(vp);
if (mp != NULL)
vn_finished_secondary_write(mp);
- if (error == ERELOOKUP)
- error = 0;
return (error);
}