diff options
| author | Mark Johnston <markj@FreeBSD.org> | 2020-07-23 14:21:45 +0000 |
|---|---|---|
| committer | Mark Johnston <markj@FreeBSD.org> | 2020-07-23 14:21:45 +0000 |
| commit | 4cbba6ae2464c05639e152c3782bef735b8fbd1f (patch) | |
| tree | c18ea42ea379e6bc250742bf48ac4e3113d4bdd4 /sys | |
| parent | cbef26ed161718002e5cb7e0eefd57c5c0c2b08d (diff) | |
| download | src-4cbba6ae2464c05639e152c3782bef735b8fbd1f.tar.gz src-4cbba6ae2464c05639e152c3782bef735b8fbd1f.zip | |
MFOpenZFS: Fix zpool history unbounded memory usage
In original implementation, zpool history will read the whole history
before printing anything, causing memory usage goes unbounded. We fix
this by breaking it into read-print iterations.
Reviewed-by: Tom Caputi <tcaputi@datto.com>
Reviewed-by: Matt Ahrens <matt@delphix.com>
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Chunwei Chen <david.chen@nutanix.com>
Closes #9516
Note, this change changes the libzfs.so ABI by modifying the prototype
of zpool_get_history(). Since libzfs is effectively private to the base
system it is anticipated that this will not be a problem.
PR: 247557
Obtained from: OpenZFS
Reported and tested by: Sam Vaughan <samjvaughan@gmail.com>
Discussed with: freqlabs
MFC after: 2 weeks
Differential Revision: https://reviews.freebsd.org/D25745
openzfs/zfs@7125a109dcc55628336ff3f58e59e503f4d7694d
Notes
Notes:
svn path=/head/; revision=363447
Diffstat (limited to 'sys')
0 files changed, 0 insertions, 0 deletions