aboutsummaryrefslogtreecommitdiff
path: root/sbin/route/route.c
Commit message (Collapse)AuthorAgeFilesLines
* Revert "SO_RERROR indicates that receive buffer overflows should be handled ↵Alexander V. Chernikov2021-02-081-12/+1
| | | | | | | | as errors." Wrong version of the change was pushed inadvertenly. This reverts commit 4a01b854ca5c2e5124958363b3326708b913af71.
* SO_RERROR indicates that receive buffer overflows should be handled as errors.Alexander V. Chernikov2021-02-081-1/+12
| | | | | | | | | | | | Historically receive buffer overflows have been ignored and programs could not tell if they missed messages or messages had been truncated because of overflows. Since programs historically do not expect to get receive overflow errors, this behavior is not the default. This is really really important for programs that use route(4) to keep in sync with the system. If we loose a message then we need to reload the full system state, otherwise the behaviour from that point is undefined and can lead to chasing bogus bug reports.
* Remove remnants of classful behavior in route(8).Alexander V. Chernikov2021-01-161-55/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Curently route(8) treats some addresses as network addresses: RTA_DST: inet 10.0.0.0; RTA_NETMASK: inet 255.0.0.0; RTA_IFP: link ; RTM_GET: Report Metrics: len 240, pid: 0, seq 1, errno 0, flags:<UP,GATEWAY,STATIC> locks: inits: sockaddrs: <DST,NETMASK,IFP> 10.0.0.0 255.0.0.0 link#0 Note added `RTA_NETMASK` in the request. Host address from the same network is ok: route -nv get 10.0.0.1 RTA_DST: inet 10.0.0.1 RTA_IFP: link RTM_GET: Report Metrics: len 224, pid: 0, seq 1, errno 0, flags:<UP,GATEWAY,HOST,STATIC> ... route to: 10.0.0.1 destination: 10.0.0.0 mask: 255.255.255.0 This change eliminates network auto-guessing part AND reading network from /etc/networks. Reviewed By: rgrimes Differential Revision: https://reviews.freebsd.org/D24401
* route(8): correctly return exit status when "-q" flag is used.Eugene Grosbein2018-10-271-4/+6
| | | | | | | | | | | Previously, route returned 1 in case of error properly signalling failure but "route -q" it returned 0 for same case. Fix it. PR: 186333 MFC after: 1 month Notes: svn path=/head/; revision=339811
* Fix memory leaks in route(8).Alexander V. Chernikov2018-03-311-0/+2
| | | | | | | | | Submitted by: Tom Rix (trix_juniper.net) MFC after: 2 weeks Differential Revision: https://reviews.freebsd.org/D9676 Notes: svn path=/head/; revision=331844
* route(8): make it possible to manually delete pinned routeEugene Grosbein2018-02-241-1/+3
| | | | | | | | | Reported by: Andreas Longwitz <longwitz@incore.de> Approved by: avg (mentor) MFC after: 1 week Notes: svn path=/head/; revision=329930
* General further adoption of SPDX licensing ID tags.Pedro F. Giffuni2017-11-201-1/+3
| | | | | | | | | | | | | | | | | Mainly focus on files that use BSD 3-Clause license. The Software Package Data Exchange (SPDX) group provides a specification to make it easier for automated tools to detect and summarize well known opensource licenses. We are gradually adopting the specification, noting that the tags are considered only advisory and do not, in any way, superceed or replace the license texts. Special thanks to Wind River for providing access to "The Duke of Highlander" tool: an older (2014) run over FreeBSD tree was useful as a starting point. Notes: svn path=/head/; revision=326025
* Fix userland tools that don't check the format of routing socketPatrick Kelsey2017-04-161-9/+10
| | | | | | | | | | | | | | | | | | | messages before accessing message fields that may not be present, removing dead/duplicate/misleading code along the way. Document the message format for each routing socket message in route.h. Fix a bug in usr.bin/netstat introduced in r287351 that resulted in pointer computation with essentially random 16-bit offsets and dereferencing of the results. Reviewed by: ae MFC after: 1 month Differential Revision: https://reviews.freebsd.org/D10330 Notes: svn path=/head/; revision=317035
* Delete trailing whitespace (no functional change)Enji Cooper2017-03-211-4/+4
| | | | | | | | MFC after: 3 days Sponsored by: Dell EMC Isilon Notes: svn path=/head/; revision=315690
* Renumber copyright clause 4Warner Losh2017-02-281-1/+1
| | | | | | | | | | | | Renumber cluase 4 to 3, per what everybody else did when BSD granted them permission to remove clause 3. My insistance on keeping the same numbering for legal reasons is too pedantic, so give up on that point. Submitted by: Jan Schaumann <jschauma@stevens.edu> Pull Request: https://github.com/freebsd/freebsd/pull/96 Notes: svn path=/head/; revision=314436
* Due to dropped mbuf in netisr queue route(8) can fall into infinityAndrey V. Elsukov2016-07-271-1/+27
| | | | | | | | | | | | | | loop of reading the rtsock's feed. When it used by some scripts, this leads to growing number of not finished route(8) instances and thus growing number of rtsock consumers. Add SIGALRM handler to prevent this. Reviewed by: melifaro Obtained from: Yandex LLC MFC after: 2 weeks Sponsored by: Yandex LLC Notes: svn path=/head/; revision=303374
* Fix /sbin/route to never look up (invalid) interface names through DNSRyan Stone2015-09-171-0/+3
| | | | | | | | | | | | | | | | /sbin/route has a bug where if it is passed an interface name that does not exist, it falls through and winds up interpreting it as a hostname. It fails out eventually, but on a system where DNS lookup is broken you can end up waiting for up to 60 seconds waiting for the DNS lookup to timeout. I'm not quite sure what happens if the DNS lookup somehow succeeds but I doubt that can end well. Reviewed by: markj, cem MFC after: 2 weeks Sponsored by: EMC/Isilon Storage Division Notes: svn path=/head/; revision=287920
* Eliminate incorrect IPv6 mask guessing:Alexander V. Chernikov2015-01-161-9/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | RFC 2374 concept of 'IPv6 Aggregatable Global Unicast Address Format' was deprecated by RFC 3587 12 years ago. Before: 15:06 [1] edge# netstat -rn6 | grep 2a02:6b8:: 2a02:6b8::/32 2a02:978:2::1 UGS em0 15:06 [1] edge# route -6n get 2a02:6b8:: route: writing to routing socket: No such process After: 15:07 [1] edge# /usr/obj/usr/src/sbin/route/route -n6 get 2a02:6b8:: route to: 2a02:6b8:: destination: 2a02:6b8:: mask: ffff:ffff:: gateway: 2a02:978:2::1 fib: 0 interface: em0 flags: <UP,GATEWAY,DONE,STATIC> recvpipe sendpipe ssthresh rtt,msec mtu weight expire 0 0 0 0 1500 1 0 MFC after: 2 weeks Notes: svn path=/head/; revision=277241
* Finish r274175: do control plane MTU tracking.Alexander V. Chernikov2014-11-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Update route MTU in case of ifnet MTU change. Add new RTF_FIXEDMTU to track explicitly specified MTU. Old behavior: ifconfig em0 mtu 1500->9000 -> all routes traversing em0 do not change MTU. User has to manually update all routes. ifconfig em0 mtu 9000->1500 -> all routes traversing em0 do not change MTU. However, if ip[6]_output finds route with rt_mtu > interface mtu, rt_mtu gets updated. New behavior: ifconfig em0 mtu 1500->9000 -> all interface routes in all fibs gets updated with new MTU unless RTF_FIXEDMTU flag set on them. ifconfig em0 mtu 9000->1500 -> all routes in all fibs gets updated with new MTU unless RTF_FIXEDMTU flag set on them AND rt_mtu is less than ifp mtu. route add ... -mtu XXX automatically sets RTF_FIXEDMTU flag. route change .. -mtu 0 automatically removes RTF_FIXEDMTU flag. PR: 194238 MFC after: 1 month CR: D1125 Notes: svn path=/head/; revision=274611
* Kill custom in_matroute() radix mathing function removing one rte mutex lock.Alexander V. Chernikov2014-11-111-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Initially in_matrote() in_clsroute() in their current state was introduced by r4105 20 years ago. Instead of deleting inactive routes immediately, we kept them in route table, setting RTPRF_OURS flag and some expire time. After that, either GC came or RTPRF_OURS got removed on first-packet. It was a good solution in that days (and probably another decade after that) to keep TCP metrics. However, after moving metrics to TCP hostcache in r122922, most of in_rmx functionality became unused. It might had been used for flushing icmp-originated routes before rte mutexes/refcounting, but I'm not sure about that. So it looks like this is nearly impossible to make GC do its work nowadays: in_rtkill() ignores non-RTPRF_OURS routes. route can only become RTPRF_OURS after dropping last reference via rtfree() which calls in_clsroute(), which, it turn, ignores UP and non-RTF_DYNAMIC routes. Dynamic routes can still be installed via received redirect, but they have default lifetime (no specific rt_expire) and no one has another trie walker to call RTFREE() on them. So, the changelist: * remove custom rnh_match / rnh_close matching function. * remove all GC functions * partially revert r256695 (proto3 is no more used inside kernel, it is not possible to use rt_expire from user point of view, proto3 support is not complete) * Finish r241884 (similar to this commit) and remove remaining IPv6 parts MFC after: 1 month Notes: svn path=/head/; revision=274363
* Put "break" after err() to please coverity.Alexander V. Chernikov2014-11-041-0/+1
| | | | | | | | Reported by: Coverity CID: 1250795 Notes: svn path=/head/; revision=274086
* Print human-readable error for "route not found" case.Alexander V. Chernikov2014-10-311-2/+11
| | | | | | | | | Submitted by: vsevolod (initial version) MFC after: 2 weeks Sponsored by: Yandex LLC Notes: svn path=/head/; revision=273906
* Fix incorrect netmasks being passed via rtsock.Alexander V. Chernikov2014-05-081-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since radix has been ignoring sa_family in passed sockaddrs, no one ever has bothered filling valid sa_family in netmasks. Additionally, radix adjusts sa_len field in every netmask not to compare zero bytes at all. This leads us to rt_mask with sa_family of AF_UNSPEC (-1) and arbitrary sa_len field (0 for default route, for example). However, rtsock have been passing that rt_mask intact for ages, requiring all rtsock consumers to make ther own local hacks. We even have unfixed on in base: do `route -n monitor` in one window and issue `route -n get addr` for some directly-connected address. You will probably see the following: got message of size 304 on Thu May 8 15:06:06 2014 RTM_GET: Report Metrics: len 304, pid: 30493, seq 1, errno 0, flags:<UP,DONE,PINNED> locks: inits: sockaddrs: <DST,GATEWAY,NETMASK,IFP,IFA> 10.0.0.0 link#1 (255) ffff ffff ff em0:8.0.27.c5.29.d4 10.0.0.92 _________________^^^^^^^^^^^^^^^^^^ after the change: got message of size 312 on Thu May 8 15:44:07 2014 RTM_GET: Report Metrics: len 312, pid: 2895, seq 1, errno 0, flags:<UP,DONE,PINNED> locks: inits: sockaddrs: <DST,GATEWAY,NETMASK,IFP,IFA> 10.0.0.0 link#1 255.255.255.0 em0:8.0.27.c5.29.d4 10.0.0.92 _________________^^^^^^^^^^^^^^^^^^ Sponsored by: Yandex LLC MFC after: 1 month Notes: svn path=/head/; revision=265666
* When switching variables to flags in r243185 a few cases were missed.Bjoern A. Zeeb2014-04-161-5/+5
| | | | | | | | | | | | | After r263152 this leaves unused variables if route(8) is compiled without INET support. Switch the remaining variable accesses to flags and remove now obsolete variables. Reviewed by: glebius MFC after: 1 week Notes: svn path=/head/; revision=264539
* Remove AppleTalk support.Gleb Smirnoff2014-03-141-64/+0
| | | | | | | | | | | | | AppleTalk was a network transport protocol for Apple Macintosh devices in 80s and then 90s. Starting with Mac OS X in 2000 the AppleTalk was a legacy protocol and primary networking protocol is TCP/IP. The last Mac OS X release to support AppleTalk happened in 2009. The same year routing equipment vendors (namely Cisco) end their support. Thus, AppleTalk won't be supported in FreeBSD 11.0-RELEASE. Notes: svn path=/head/; revision=263152
* Add -4/-6 shorthand for -finet/-finet6 in route(8) and netstat(8).Alexander V. Chernikov2014-01-101-2/+22
| | | | | | | MFC after: 2 weeks Notes: svn path=/head/; revision=260524
* Do some more sanity checks in route(8): require netmask to haveAlexander V. Chernikov2014-01-091-0/+7
| | | | | | | | | | the same address family as destination. Found by: jmg MFC after: 2 weeks Notes: svn path=/head/; revision=260472
* route(1): Pull static data to the top of the file.Eitan Adler2013-12-041-15/+15
| | | | | | | | | | This is a pre-requisisite to some upcoming changes. Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> Discussed on: -hackers Notes: svn path=/head/; revision=258940
* route(1): Pull static buffer out of the function and into function scope.Eitan Adler2013-12-041-17/+17
| | | | | | | | | | This will make it easier to link as a library. Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> Discussed on: -hackers Notes: svn path=/head/; revision=258939
* route(1): Pull static buffer out of the function and into function scope.Eitan Adler2013-12-041-13/+13
| | | | | | | | | | This will make it easier to link as a library. Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> (older version) Discussed on: -hackers Notes: svn path=/head/; revision=258938
* route(1): Pull static variable out of the function and into function scope.Eitan Adler2013-12-041-3/+3
| | | | | | | | | | This will make it easier to link as a library. Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> (older version) Discussed on: -hackers Notes: svn path=/head/; revision=258937
* route(1): Pull static buffer out of the function and into function scope.Eitan Adler2013-12-041-4/+5
| | | | | | | | | | This will make it easier to link as a library. Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> (older version) Discussed on: -hackers Notes: svn path=/head/; revision=258934
* Avoid using a static buffer in atalk_ntoa. This will help allow users to ↵Eitan Adler2013-12-041-9/+15
| | | | | | | | | | | call route(1) as a library. Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> (older version) Discussed on: -hackers Reviwed by: adri (different older version) Notes: svn path=/head/; revision=258908
* Add const qualifier where appropriateEitan Adler2013-12-041-2/+2
| | | | | | | Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> Notes: svn path=/head/; revision=258907
* Add const qualifier where appropriateEitan Adler2013-12-041-1/+1
| | | | | | | Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> Notes: svn path=/head/; revision=258906
* Turn 'n' into a local variable. This is required for additional changes.Eitan Adler2013-12-041-1/+2
| | | | | | | Submitted by: Sebastian Huber <sebastian.huber@embedded-brains.de> Notes: svn path=/head/; revision=258905
* Use long explicitly for the time difference.Hiroki Sato2013-10-181-1/+2
| | | | Notes: svn path=/head/; revision=256715
* - Add relative specification in expiration time.Hiroki Sato2013-10-171-10/+29
| | | | | | | | - Add proto3 option for RTF_PROTO3. - Use %lu for members of struct rt_metrics. Notes: svn path=/head/; revision=256695
* When destination parameter is missing, exit with a clear synopsis,Gleb Smirnoff2013-10-081-0/+5
| | | | | | | | | | | instead of writing to kernel and printing EINVAL description. PR: bin/181532 Submitted by: Kurt Jaeger <fbsd-pr opsec.eu> Approved by: re (hrs) Notes: svn path=/head/; revision=256137
* Fix boundary check of sockaddr array.Hiroki Sato2013-08-011-3/+2
| | | | | | | Reported by: uqs Notes: svn path=/head/; revision=253852
* Fix a bug in cp += SA_SIZE() in RTA_* loop. This could preventHiroki Sato2013-07-241-8/+7
| | | | | | | | | RTA_IFP from displaying correctly in route get subcommand. Spotted by: dim Notes: svn path=/head/; revision=253589
* - Use getnameinfo() for both of AF_INET and AF_INET6 in routename().Hiroki Sato2013-07-211-46/+54
| | | | | | | - Add missing "static". Notes: svn path=/head/; revision=253519
* - Fix nflag in routename().Hiroki Sato2013-07-211-10/+33
| | | | | | | | | | - Display a AF_LINK address in #linkN when sdl_{nlen,alen,slen) == 0 and sdl_index != 0. - Reduce unnecessary loop in pmsg_addrs(). - Remove iso_ntoa(). This is not used. Notes: svn path=/head/; revision=253517
* - Simplify getaddr() and print_getmsg() by using RTAX_* instead of RTA_*Hiroki Sato2013-07-201-80/+48
| | | | | | | | as the argument. - Reduce unnecessary loop in print_getmsg(). Notes: svn path=/head/; revision=253504
* Show "default" for the zero-filled address consistently when nflag == 0.Hiroki Sato2013-07-201-13/+10
| | | | Notes: svn path=/head/; revision=253503
* Add cast to (void *) to the following cases to suppress warnings byHiroki Sato2013-07-201-24/+23
| | | | | | | | | | -Wcast-align. These do not increase the alignment requirement: - rtm = (struct rt_msghdr *)(rtm + rtm->rtm_msglen) - struct sockaddr *sa = &sa0; sX = (struct sockaddr_X *)sa Notes: svn path=/head/; revision=253502
* Fix a gcc warning.Hiroki Sato2013-07-181-1/+4
| | | | | | | Pointy hat to: hrs Notes: svn path=/head/; revision=253443
* Use NET_RT_DUMP.0.FIB leaf node instead of setting td_proc->p_fibnum.Hiroki Sato2013-07-171-12/+2
| | | | Notes: svn path=/head/; revision=253429
* - Add support of MK_INET_SUPPORT=no.Hiroki Sato2013-07-171-266/+275
| | | | | | | | | | | | | | | - Fix a bug in sodump() which prevented struct sockaddr_in6 from displaying. - Fix a bug in in fiboptlist_csv() which could cause free() of uninitialized pointer. - Style cleanups: . Add missing "static" keywords. . Use an array of struct sockaddr_storage instead of sockunion for rtmsg. . Use err() and errx() instead of pair of fprintf(stderr, "...") + exit(1). . Use nitems() macro. . Various style(9) fixes. Notes: svn path=/head/; revision=253427
* Fix a bug that the gateway address was not shown when a -gateway modifierHiroki Sato2013-06-091-0/+1
| | | | | | | was used. Notes: svn path=/head/; revision=251581
* Retire struct sockaddr_inarp.Gleb Smirnoff2013-01-311-4/+1
| | | | | | | | | | | | | | | | | | Since ARP and routing are separated, "proxy only" entries don't have any meaning, thus we don't need additional field in sockaddr to pass SIN_PROXY flag. New kernel is binary compatible with old tools, since sizes of sockaddr_inarp and sockaddr_in match, and sa_family are filled with same value. The structure declaration is left for compatibility with third party software, but in tree code no longer use it. Reviewed by: ru, andre, net@ Notes: svn path=/head/; revision=246143
* Fix -iface and -interface modifiers.Hiroki Sato2013-01-081-14/+14
| | | | | | | Spotted by: Ian FREISLICH Notes: svn path=/head/; revision=245168
* - Fix strtol() error handling.Hiroki Sato2012-12-161-16/+35
| | | | | | | | | | | - Add a range condition of given FIB number and the related error messages. - Fix free() problem. Spotted by: Artyom Mirgorodskiy Discussed with: glebius Notes: svn path=/head/; revision=244325
* - Move definition of V_deembed_scopeid to scope6_var.h.Hiroki Sato2012-12-051-10/+0
| | | | | | | | | - Deembed scope id in L3 address in in6_lltable_dump(). - Simplify scope id recovery in rtsock routines. - Remove embedded scope id handling in ndp(8) and route(8) completely. Notes: svn path=/head/; revision=243903
* Fix fallout from r243019, which broke parsing of shortened networkGleb Smirnoff2012-12-041-0/+7
| | | | | | | | | prefixes. Reported and tested by: delphij Notes: svn path=/head/; revision=243867