aboutsummaryrefslogtreecommitdiff
path: root/sys/dev/vge
Commit message (Collapse)AuthorAgeFilesLines
* Mechanically convert to if_inc_counter().Gleb Smirnoff2014-09-181-13/+14
| | | | Notes: svn path=/head/; revision=271815
* Use define from if_var.h to access a field inside struct if_data,Gleb Smirnoff2014-08-301-1/+1
| | | | | | | | | that resides in struct ifnet. Sponsored by: Nginx, Inc. Notes: svn path=/head/; revision=270856
* Fix various NIC drivers to properly cleanup static DMA resources.John Baldwin2014-06-111-8/+6
| | | | | | | | | | | | | | | | | | In particular, don't check the value of the bus_dma map against NULL to determine if either bus_dmamem_alloc() or bus_dmamap_load() succeeded. Instead, assume that bus_dmamap_load() succeeeded (and thus that bus_dmamap_unload() should be called) if the bus address for a resource is non-zero, and assume that bus_dmamem_alloc() succeeded (and thus that bus_dmamem_free() should be called) if the virtual address for a resource is not NULL. In many cases these bugs could result in leaks when a driver was detached. Reviewed by: yongari MFC after: 2 weeks Notes: svn path=/head/; revision=267363
* The r48589 promised to remove implicit inclusion of if_var.h soon. PrepareGleb Smirnoff2013-10-261-0/+1
| | | | | | | | | | | to this event, adding if_var.h to files that do need it. Also, include all includes that now are included due to implicit pollution via if_var.h Sponsored by: Netflix Sponsored by: Nginx, Inc. Notes: svn path=/head/; revision=257176
* Mechanically substitute flags from historic mbuf allocator withGleb Smirnoff2012-12-041-4/+4
| | | | | | | malloc(9) flags in sys/dev. Notes: svn path=/head/; revision=243857
* Remove unused variable miiKevin Lo2012-02-111-2/+0
| | | | Notes: svn path=/head/; revision=231510
* - There's no need to overwrite the default device method with the defaultMarius Strobl2011-11-221-5/+1
| | | | | | | | | | | | | one. Interestingly, these are actually the default for quite some time (bus_generic_driver_added(9) since r52045 and bus_generic_print_child(9) since r52045) but even recently added device drivers do this unnecessarily. Discussed with: jhb, marcel - While at it, use DEVMETHOD_END. Discussed with: jhb - Also while at it, use __FBSDID. Notes: svn path=/head/; revision=227843
* Announce flow control capability to underlying PHY driver.Pyun YongHyeon2011-11-221-4/+11
| | | | | | | | | Pause timer value is initialized to 0xFFFF. Controller allows just 4 different TX pause thresholds. The lowest possible threshold value looks too aggressive so use next available threshold value. Notes: svn path=/head/; revision=227837
* Rework link establishment and link state detection logic.Pyun YongHyeon2011-11-221-18/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove MIIBUS statchg callback and program VGE_DIAGCTL before initiating link establishment. Previously driver used to program VGE_DIAGCTL after getting a link in statchg callback. It seems the VGE_DIAGCTL register works like a kind of MII register such that it requires setting a 'to be' mode in advance rather than relying on resolved speed/duplex of established link. This means the statchg callback is not needed in driver. In addition, if there was no link at the time of media change, this was not called at all. - Introduce vge_ifmedia_upd_locked() to change current media to configured one. Actual media change is performed only after PHY reset and VGE_DIAGCTL setup. - In WOL configuration, make sure to clear forced mode such that controller can rely on auto-negotiation. - Unlike most other drivers that use miibus(4), vge(4) used controller's auto-polling feature for link state tracking via interrupt. This came from controller's inefficient mechanism to access MII registers. On link state change interrupt, vge(4) used to get current link state with series of MII register accesses. Because vge(4) already enabled auto polling, read PHY status register to resolved speed/duplex/flow control parameters. vge(4) still does not drive MII_TICK to reduce number of MII register accesses which in turn means the driver does not know the status of auto-negotiation. This was a one of long standing issue of vge(4). Probably driver may be able to implement a timer that keeps track of auto-negotiation state and restart auto-negotiation when driver couldn't establish a link within a specified period. However the controller does not provide a reliable way to detect auto-negotiation failure so I'm not sure whether it's worth to implement it in driver. Alternatively driver can completely disable MII auto-polling and let miibus(4) poll link state by driving MII_TICK. This may reduce unnecessary overhead of stopping/restarting MII auto-polling of controller. Unfortunately it was known that some variants of controller does not work correctly if MII auto-polling is disabled. Notes: svn path=/head/; revision=227835
* Always start MII auto polling before accessing any MII registers.Pyun YongHyeon2011-11-221-0/+2
| | | | Notes: svn path=/head/; revision=227828
* Close a race where SIOCGIFMEDIA ioctl get inconsistent link status.Pyun YongHyeon2011-10-171-1/+1
| | | | | | | | | | | Because driver is accessing a common MII structure in mii_pollstat(), updating user supplied structure should be done before dropping a driver lock. Reported by: Karim (fodillemlinkarimi <> gmail dot com) Notes: svn path=/head/; revision=226478
* vge(4) hardwares poll media status and generates an interruptPyun YongHyeon2011-09-072-7/+13
| | | | | | | | | | | | | | | | | | | | | | whenever the link state is changed. Using software based polling for media status tracking is known to cause MII access failure under certain conditions once link is established so vge(4) used to rely on link status change interrupt. However DEVICE_POLLING completely disables generation of all kind of interrupts on vge(4) such that this resulted in not detecting link state change event. This means vge(4) does not correctly detect established/lost link with DEVICE_POLLING. Losing the interrupt made vge(4) not to send any packets to peer since vge(4) does not try to send any packets when there is no established link. Work around the issue by generating link state change interrupt with DEVICE_POLLING. PR: kern/160442 Approved by: re (kib) Notes: svn path=/head/; revision=225440
* Datasheet says vge(4) controllers support DAC but it seems that'sPyun YongHyeon2011-05-201-2/+17
| | | | | | | | | | | | | | | not true on old PCI based controllers. DAC configuration is read from EEPROM in device reset phase and driver can override DAC configuration. However I guess there is an undocumented reason why EEPROM configuration does not enable DAC so do not blindly override DAC configuration. Recent PCIe based controllers are supposed to support 64bit DMA so allow 64bit DMA only on PCIe based controllers. PR: kern/157184 MFC after: 1 week Notes: svn path=/head/; revision=222142
* Do a sweep of the tree replacing calls to pci_find_extcap() with calls toJohn Baldwin2011-03-231-2/+2
| | | | | | | pci_find_cap() instead. Notes: svn path=/head/; revision=219902
* Convert the PHY drivers to honor the mii_flags passed down and convertMarius Strobl2010-10-151-10/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | the NIC drivers as well as the PHY drivers to take advantage of the mii_attach() introduced in r213878 to get rid of certain hacks. For the most part these were: - Artificially limiting miibus_{read,write}reg methods to certain PHY addresses; we now let mii_attach() only probe the PHY at the desired address(es) instead. - PHY drivers setting MIIF_* flags based on the NIC driver they hang off from, partly even based on grabbing and using the softc of the parent; we now pass these flags down from the NIC to the PHY drivers via mii_attach(). This got us rid of all such hacks except those of brgphy() in combination with bce(4) and bge(4), which is way beyond what can be expressed with simple flags. While at it, I took the opportunity to change the NIC drivers to pass up the error returned by mii_attach() (previously by mii_phy_probe()) and unify the error message used in this case where and as appropriate as mii_attach() actually can fail for a number of reasons, not just because of no PHY(s) being present at the expected address(es). Reviewed by: jhb, yongari Notes: svn path=/head/; revision=213893
* Remove wrong assertion.Pyun YongHyeon2009-12-251-2/+0
| | | | Notes: svn path=/head/; revision=200972
* Disable jumbo frame support for PCIe VT6130/VT6132 controllers.Pyun YongHyeon2009-12-202-3/+13
| | | | | | | | | | | | | | Quite contrary to VT6130 datasheet which says it supports up to 8K jumbo frame, VT6130 does not seem to send jumbo frame that is larger than 4K in length. Trying to send a frame that is larger than 4K cause TX MAC hang. Even though it's possible to allow 4K jumbo frame for VT6130, I think it's meaningless to allow 4K jumbo frame. I'm not sure VT6132 also has the same limitation but I guess it uses the same MAC of VT6130. Notes: svn path=/head/; revision=200759
* VT6130 datasheet was wrong. If VT6130 receive a jumbo frame thePyun YongHyeon2009-12-201-1/+1
| | | | | | | | | | | | controller will split the jumbo frame into multiple RX buffers. However it seems the hardware always dma the frame to 8 bytes boundary for the split frames. Only the first part of the fragment can have 4 byte alignment and subsequent buffers should be 8 bytes aligned. Change RX buffer the alignment requirement to 8 bytes from 4 bytes. Notes: svn path=/head/; revision=200758
* Correct fragment bit definition in comments.Pyun YongHyeon2009-12-201-2/+2
| | | | Notes: svn path=/head/; revision=200756
* Swap VGE_TXQTIMER and VGE_RXQTIMER register definition. PendingPyun YongHyeon2009-12-191-2/+2
| | | | | | | timer for Tx queue is at 0x3E. Notes: svn path=/head/; revision=200740
* Add rudimentary WOL support. While I'm here remove enablingPyun YongHyeon2009-12-183-17/+227
| | | | | | | | busmastering/memory address in resume path. Bus driver will handle that. Notes: svn path=/head/; revision=200696
* Remove unused member variable of softc.Pyun YongHyeon2009-12-171-1/+0
| | | | Notes: svn path=/head/; revision=200644
* Actually clear interrupts. Writing 0 has no effect.Pyun YongHyeon2009-12-171-1/+1
| | | | Notes: svn path=/head/; revision=200639
* Implement interrupt moderation scheme supported by VT61xxPyun YongHyeon2009-12-173-80/+103
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | controllers. TX/RX interrupt mitigation is controlled by VGE_TXSUPPTHR and VGE_RXSUPPTHR register. These registers suppress generation of interrupts until the programmed frames counter equals to the registers. VT61xx also supports interrupt hold off timer register. If this interrupt hold off timer is active all interrupts would be disabled until the timer reaches to 0. The timer value is reloaded whenever VGE_ISR register written. The timer resolution is about 20us. Previously vge(4) used single shot timer to reduce Tx completion interrupts. This required VGE_CRS1 register access in Tx start/completion handler to rearm new timeout value and it did not show satisfactory result(more than 50k interrupts under load). Rx interrupts was not moderated at all such that vge(4) used to generate too many interrupts which in turn made polling(4) better approach under high network load. This change activates all interrupt moderation mechanism and initial values were tuned to generate interrupt less than 8k per second. That number of interrupts wouldn't add additional packet latencies compared to polling(4). These interrupt parameters could be changed with sysctl. dev.vge.%d.int_holdoff dev.vge.%d.rx_coal_pkt dev.vge.%d.tx_coal_pkt Interface has be brought down and up again before change take effect. With interrupt moderation there is no more need to loop in interrupt handler. This loop always added one more register access. While I'm here remove dead code which tried to implement subset of interrupt moderation. Notes: svn path=/head/; revision=200638
* Remove unused VGE_ETHER_ALIGN definition.Pyun YongHyeon2009-12-171-6/+0
| | | | Notes: svn path=/head/; revision=200635
* Add "Velocity" to probe message which will make it clearer whichPyun YongHyeon2009-12-161-1/+1
| | | | | | | | | | ethernet controller was recognized. VIA consistently calls "Velocity" family for gigabit ethernet controllers. For fast ethernet controllers they uses "Rhine" family(vr(4) controllers)) and vr(4) already shows "Rhine" in probe message. Notes: svn path=/head/; revision=200617
* Add new flag VGE_FLAG_SUSPENDED to mark suspended state andPyun YongHyeon2009-12-162-11/+6
| | | | | | | remove suspended member in softc. Notes: svn path=/head/; revision=200616
* Add hardware MAC statistics support. This statistics could bePyun YongHyeon2009-12-163-3/+322
| | | | | | | extracted from dev.vge.%d.stats sysctl node. Notes: svn path=/head/; revision=200615
* Rewrite RX filter setup and simplify code.Pyun YongHyeon2009-12-161-57/+44
| | | | | | | | Now promiscuous mode and multicast handling is performed in single function, vge_rxfilter(). Notes: svn path=/head/; revision=200613
* All vge(4) controllers support RX/TX checksum offloading for VLANPyun YongHyeon2009-12-161-6/+33
| | | | | | | | | tagged frames so add checksum offloading capabilities. Also add missing VLAN hardware tagging control in ioctl handler and let upper stack know current VLAN capabilities. Notes: svn path=/head/; revision=200609
* Tell upper layer vge(4) supports long frames. This should be donePyun YongHyeon2009-12-141-1/+3
| | | | | | | | | | after ether_ifattach(), as ether_ifattach() initializes it with ETHER_HDR_LEN. While I'm here remove setting if_mtu, it's already handled in ether_ifattach(). Notes: svn path=/head/; revision=200558
* Don't report current link status if interface is not UP.Pyun YongHyeon2009-12-141-0/+4
| | | | | | | | If interface is not UP, the current link status wouldn't reflect the negotiated status. Notes: svn path=/head/; revision=200555
* Report media change result to caller instead of returning successPyun YongHyeon2009-12-141-2/+3
| | | | | | | without regard to the result. Notes: svn path=/head/; revision=200552
* Whenever link state change interrupt is raised, vge_tick() isPyun YongHyeon2009-12-141-4/+4
| | | | | | | | | | | | | called and vge(4) used to drive auto-negotiation timer(mii_tick) in vge_tick(). Therefore the mii_tick was not called for every hz such that auto-negotiation complete was never handled in vge(4). Use mii_pollstat to extract current negotiated speed/duplex instead of mii_tick. The latter is valid only for auto-negotiation case. While I'm here change the confusing function name vge_tick() to vge_link_statchg(). Notes: svn path=/head/; revision=200551
* Sort function prototyes.Pyun YongHyeon2009-12-141-48/+44
| | | | Notes: svn path=/head/; revision=200548
* We don't have to reload EEPROM in vge_reset(). Because vge_reset()Pyun YongHyeon2009-12-141-17/+17
| | | | | | | | | is called in vge_init_lock(), vge(4) always used to reload EEPROM. Also add more comment why vge(4) clears VGE_CHIPCFG0_PACPI bit. While I'm here add missing new line in vge_reset(). Notes: svn path=/head/; revision=200545
* Increase output queue size from 64 to 255.Pyun YongHyeon2009-12-142-4/+2
| | | | Notes: svn path=/head/; revision=200543
* Add MSI support for VT613x controllers.Pyun YongHyeon2009-12-142-5/+25
| | | | Notes: svn path=/head/; revision=200541
* Save PHY address by reading VGE_MIICFG register. For PCIePyun YongHyeon2009-12-142-4/+22
| | | | | | | | | | | controllers(VT613x), we assume the PHY address is 1. Use the saved PHY address in MII register access routines and remove accessing VGE_MIICFG register. While I'm here save PCI express capability register which will be used in near future. Notes: svn path=/head/; revision=200540
* Introduce vge_flags member in softc. The vge_flags member willPyun YongHyeon2009-12-142-7/+7
| | | | | | | | | record device specific bits. Remove vge_link and use vge_flags. While here, move clearing link state before mii_mediachg() as mii_mediachg() may affect link state. Notes: svn path=/head/; revision=200538
* style(9).Pyun YongHyeon2009-12-141-105/+105
| | | | Notes: svn path=/head/; revision=200536
* s/u_intXX_t/uintXX_t/gPyun YongHyeon2009-12-142-10/+10
| | | | Notes: svn path=/head/; revision=200533
* Remove unnecessary return statement.Pyun YongHyeon2009-12-141-22/+0
| | | | Notes: svn path=/head/; revision=200532
* Use ANSI function definations.Pyun YongHyeon2009-12-141-95/+38
| | | | Notes: svn path=/head/; revision=200531
* Clear VGE_TXDESC_Q bit for transmitted frames. The VGE_TXDESC_Q bitPyun YongHyeon2009-12-141-1/+4
| | | | | | | | | | | | | | | seems to work like a tag that indicates 'not list end' of queued frames. Without having a VGE_TXDESC_Q bit indicates 'list end'. So the last frame of multiple queued frames has no VGE_TXDESC_Q bit. The hardware has peculiar behavior for VGE_TXDESC_Q bit handling. If the VGE_TXDESC_Q bit of descriptor was set the controller would fetch next descriptor. However if next descriptor's OWN bit was cleared but VGE_TXDESC_Q was set, it could confuse controller. Clearing VGE_TXDESC_Q bit for transmitted frames ensure correct behavior. Notes: svn path=/head/; revision=200529
* Fix typo in register definition.Pyun YongHyeon2009-12-141-4/+4
| | | | Notes: svn path=/head/; revision=200527
* Use PCIR_BAR instead of hard-coded value.Pyun YongHyeon2009-12-141-5/+2
| | | | Notes: svn path=/head/; revision=200526
* Overhaul bus_dma(9) usage and fix various things.Pyun YongHyeon2009-12-143-697/+845
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | o Separate TX/RX buffer DMA tag from TX/RX descriptor ring DMA tag. o Separate RX buffer DMA tag from common buffer DMA tag. RX DMA tag has different restriction compared to TX DMA tag. o Add 40bit DMA address support. o Adjust TX/RX descriptor ring alignment to 64 bytes from 256 bytes as documented in datasheet. o Added check to ensure TX/RX ring reside within a 4GB boundary. Since TX/RX ring shares the same high address register they should have the same high address. o TX/RX side bus_dmamap_load_mbuf_sg(9) support. o Add lock assertion to vge_setmulti(). o Add RX spare DMA map to recover from DMA map load failure. o Add optimized RX buffer handler, vge_discard_rxbuf which is activated when vge(4) sees bad frames. o Don't blindly update VGE_RXDESC_RESIDUECNT register. Datasheet says the register should be updated only when number of available RX descriptors are multiple of 4. o Use __NO_STRICT_ALIGNMENT instead of defining VGE_FIXUP_RX which is only set for i386 architecture. Previously vge(4) also performed expensive copy operation to align IP header on amd64. This change should give RX performance boost on amd64 architecture. o Don't reinitialize controller if driver is already running. This should reduce number of link state flipping. o Since vge(4) drops a driver lock before passing received frame to upper layer, make sure vge(4) is still running after re-acquiring driver lock. o Add second argument count to vge_rxeof(). The argument will limit number of packets could be processed in RX handler. o Rearrange vge_rxeof() not to allocate RX buffer if received frame was bad packet. o Removed if_printf that prints DMA map failure. This type of message shouldn't be used in fast path of driver. o Reduce number of allowed TX buffer fragments to 6 from 7. A TX descriptor allows 7 fragments of a frame. However the CMZ field of descriptor has just 3bits and the controller wants to see fragment + 1 in the field. So if we have 7 fragments the field value would be 0 which seems to cause unexpected results under certain conditions. This change should fix occasional TX hang observed on vge(4). o Simplify vge_stat_locked() and add number of available TX descriptor check. o vge(4) controllers lack padding short frames. Make sure to fill zero for the padded bytes. This closes unintended information disclosure. o Don't set VGE_TDCTL_JUMBO flag. Datasheet is not clear whether this bit should be set by driver or write-back status bit after transmission. At least vendor's driver does not set this bit so remove it. Without this bit vge(4) still can send jumbo frames. o Don't start driver when vge(4) know there are not enough RX buffers. o Remove volatile keyword in RX descriptor structure. This should be handled by bus_dma(9). o Collapse two 16bits member of TX/RX descriptor into single 32bits member. o Reduce number of RX descriptors to 252 from 256. The VGE_RXDESCNUM is 16bits register but only lower 8bits are valid. So the maximum number of RX descriptors would be 255. However the number of should be multiple of 4 as controller wants to update 4 RX descriptors at a time. This limits the maximum number of RX descriptor to be 252. Tested by: Dewayne Geraghty (dewayne.geraghty <> heuristicsystems dot com dot au) Carey Jones (m.carey.jones <> gmail dot com) Yoshiaki Kasahara (kasahara <> nc dor kyushu-u dot ac dotjp) Notes: svn path=/head/; revision=200525
* Prefer bus_alloc_resource_any(9) to bus_alloc_resource(9).Pyun YongHyeon2009-12-141-4/+4
| | | | Notes: svn path=/head/; revision=200522
* Fix spelling in comment.Pyun YongHyeon2009-12-141-3/+3
| | | | Notes: svn path=/head/; revision=200521
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-24 03:24:13 +0000