From 4eb18346d1cd36edd593cd9b49f6095549910ef2 Mon Sep 17 00:00:00 2001 From: Mark Johnston Date: Sun, 18 Jun 2017 16:43:57 +0000 Subject: Avoid including list.h in LinuxKPI headers. list.h includes a number of FreeBSD headers as a workaround for the LIST_HEAD name collision. To reduce pollution, avoid including list.h in commonly used headers when it is not explicitly needed. Reviewed by: hselasky MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D11249 --- sys/compat/linuxkpi/common/include/linux/completion.h | 1 - sys/compat/linuxkpi/common/include/linux/kernel.h | 1 - sys/compat/linuxkpi/common/include/linux/kobject.h | 1 + sys/compat/linuxkpi/common/include/linux/mm_types.h | 1 - sys/compat/linuxkpi/common/include/linux/sched.h | 1 - sys/contrib/rdma/krping/krping.c | 1 + sys/ofed/drivers/infiniband/core/fmr_pool.c | 1 + sys/ofed/drivers/infiniband/core/iwcm.c | 1 + sys/ofed/drivers/infiniband/core/umem.c | 1 + sys/ofed/drivers/infiniband/hw/mthca/mthca_dev.h | 1 + 10 files changed, 6 insertions(+), 4 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/linux/completion.h b/sys/compat/linuxkpi/common/include/linux/completion.h index 73c1a99dfc44..92ccc61f38da 100644 --- a/sys/compat/linuxkpi/common/include/linux/completion.h +++ b/sys/compat/linuxkpi/common/include/linux/completion.h @@ -32,7 +32,6 @@ #define _LINUX_COMPLETION_H_ #include -#include struct completion { unsigned int done; diff --git a/sys/compat/linuxkpi/common/include/linux/kernel.h b/sys/compat/linuxkpi/common/include/linux/kernel.h index 3631ba5f2428..b8d2bd3b66a5 100644 --- a/sys/compat/linuxkpi/common/include/linux/kernel.h +++ b/sys/compat/linuxkpi/common/include/linux/kernel.h @@ -49,7 +49,6 @@ #include #include #include -#include #include #include diff --git a/sys/compat/linuxkpi/common/include/linux/kobject.h b/sys/compat/linuxkpi/common/include/linux/kobject.h index a000c4eebc10..261f35539469 100644 --- a/sys/compat/linuxkpi/common/include/linux/kobject.h +++ b/sys/compat/linuxkpi/common/include/linux/kobject.h @@ -35,6 +35,7 @@ #include #include +#include #include struct kobject; diff --git a/sys/compat/linuxkpi/common/include/linux/mm_types.h b/sys/compat/linuxkpi/common/include/linux/mm_types.h index 6b13dfd9b62c..44aad34c9ba2 100644 --- a/sys/compat/linuxkpi/common/include/linux/mm_types.h +++ b/sys/compat/linuxkpi/common/include/linux/mm_types.h @@ -30,7 +30,6 @@ #define _LINUX_MM_TYPES_H_ #include -#include #include #include diff --git a/sys/compat/linuxkpi/common/include/linux/sched.h b/sys/compat/linuxkpi/common/include/linux/sched.h index 01d44a0ce1e7..da30db96d6b1 100644 --- a/sys/compat/linuxkpi/common/include/linux/sched.h +++ b/sys/compat/linuxkpi/common/include/linux/sched.h @@ -37,7 +37,6 @@ #include #include -#include #include #include #include diff --git a/sys/contrib/rdma/krping/krping.c b/sys/contrib/rdma/krping/krping.c index 8a89f80e3ea3..7995b3bddff5 100644 --- a/sys/contrib/rdma/krping/krping.c +++ b/sys/contrib/rdma/krping/krping.c @@ -44,6 +44,7 @@ __FBSDID("$FreeBSD$"); #include #include #include +#include #include diff --git a/sys/ofed/drivers/infiniband/core/fmr_pool.c b/sys/ofed/drivers/infiniband/core/fmr_pool.c index c73196aa876a..733aa38b363a 100644 --- a/sys/ofed/drivers/infiniband/core/fmr_pool.c +++ b/sys/ofed/drivers/infiniband/core/fmr_pool.c @@ -37,6 +37,7 @@ #include #include #include +#include #include diff --git a/sys/ofed/drivers/infiniband/core/iwcm.c b/sys/ofed/drivers/infiniband/core/iwcm.c index a40d9dc8bbe9..5c79cdcd2595 100644 --- a/sys/ofed/drivers/infiniband/core/iwcm.c +++ b/sys/ofed/drivers/infiniband/core/iwcm.c @@ -50,6 +50,7 @@ #include #include #include +#include #include #include diff --git a/sys/ofed/drivers/infiniband/core/umem.c b/sys/ofed/drivers/infiniband/core/umem.c index 70fdea20e025..6c1a1e670664 100644 --- a/sys/ofed/drivers/infiniband/core/umem.c +++ b/sys/ofed/drivers/infiniband/core/umem.c @@ -40,6 +40,7 @@ #include #include #include +#include #include #include #include diff --git a/sys/ofed/drivers/infiniband/hw/mthca/mthca_dev.h b/sys/ofed/drivers/infiniband/hw/mthca/mthca_dev.h index 14e3f6288aa3..a6dfc6d307d2 100644 --- a/sys/ofed/drivers/infiniband/hw/mthca/mthca_dev.h +++ b/sys/ofed/drivers/infiniband/hw/mthca/mthca_dev.h @@ -45,6 +45,7 @@ #include #include #include +#include #include "mthca_provider.h" #include "mthca_doorbell.h" -- cgit v1.2.3