From 13b203d0d78cc08a7e0da8e8d5eb8c1a5d94ab69 Mon Sep 17 00:00:00 2001 From: Robert Watson Date: Wed, 3 Aug 2005 00:18:35 +0000 Subject: Modify device drivers supporting multicast addresses to lock if_addr_mtx over iteration of their multicast address lists when synchronizing the hardware address filter with the network stack-maintained list. Problem reported by: Ed Maste (emaste at phaedrus dot sandvine dot ca> MFC after: 1 week --- sys/dev/fe/if_fe.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'sys/dev/fe') diff --git a/sys/dev/fe/if_fe.c b/sys/dev/fe/if_fe.c index 643f3e432de5..8b54c011a7a3 100644 --- a/sys/dev/fe/if_fe.c +++ b/sys/dev/fe/if_fe.c @@ -2060,6 +2060,7 @@ fe_mcaf ( struct fe_softc *sc ) struct ifmultiaddr *ifma; filter = fe_filter_nothing; + IF_ADDR_LOCK(sc->ifp); TAILQ_FOREACH(ifma, &sc->ifp->if_multiaddrs, ifma_link) { if (ifma->ifma_addr->sa_family != AF_LINK) continue; @@ -2072,6 +2073,7 @@ fe_mcaf ( struct fe_softc *sc ) filter.data[index >> 3] |= 1 << (index & 7); } + IF_ADDR_UNLOCK(sc->ifp); return ( filter ); } -- cgit v1.2.3