From 95108cadbce133c49d1d442e83e92fcd545cf197 Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Sun, 3 Mar 2019 03:36:33 +0000 Subject: Add ABORTED_BY_REQUEST to the list of things we look at DNR bit and tell why to comment (code already does this) --- sys/dev/nvme/nvme_qpair.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'sys/dev/nvme/nvme_qpair.c') diff --git a/sys/dev/nvme/nvme_qpair.c b/sys/dev/nvme/nvme_qpair.c index c0eeb6da6be7..5c46e247ccf1 100644 --- a/sys/dev/nvme/nvme_qpair.c +++ b/sys/dev/nvme/nvme_qpair.c @@ -331,7 +331,8 @@ nvme_completion_is_retry(const struct nvme_completion *cpl) * TODO: spec is not clear how commands that are aborted due * to TLER will be marked. So for now, it seems * NAMESPACE_NOT_READY is the only case where we should - * look at the DNR bit. + * look at the DNR bit. Requests failed with ABORTED_BY_REQUEST + * set the DNR bit correctly since the driver controls that. */ switch (sct) { case NVME_SCT_GENERIC: -- cgit v1.2.3