From d3ce8327194c0bcf742f2e03b5b0dc8f8cfe7f6b Mon Sep 17 00:00:00 2001 From: Ed Schouten Date: Fri, 26 Sep 2008 14:19:52 +0000 Subject: Remove unit2minor() use from kernel code. When I changed kern_conf.c three months ago I made device unit numbers equal to (unneeded) device minor numbers. We used to require bitshifting, because there were eight bits in the middle that were reserved for a device major number. Not very long after I turned dev2unit(), minor(), unit2minor() and minor2unit() into macro's. The unit2minor() and minor2unit() macro's were no-ops. We'd better not remove these four macro's from the kernel, because there is a lot of (external) code that may still depend on them. For now it's harmless to remove all invocations of unit2minor() and minor2unit(). Reviewed by: kib --- sys/netsmb/smb_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'sys/netsmb') diff --git a/sys/netsmb/smb_dev.c b/sys/netsmb/smb_dev.c index 3181438b4657..c77297eec409 100644 --- a/sys/netsmb/smb_dev.c +++ b/sys/netsmb/smb_dev.c @@ -108,7 +108,7 @@ nsmb_dev_clone(void *arg, struct ucred *cred, char *name, int namelen, return; if (dev_stdclone(name, NULL, NSMB_NAME, &u) != 1) return; - *dev = make_dev(&nsmb_cdevsw, unit2minor(u), 0, 0, 0600, + *dev = make_dev(&nsmb_cdevsw, u, 0, 0, 0600, NSMB_NAME"%d", u); dev_ref(*dev); } -- cgit v1.2.3