From 92f9212ba6ab4a7fc1265883eb3292d42e6dde9b Mon Sep 17 00:00:00 2001 From: Warner Losh Date: Fri, 26 Oct 2018 23:44:39 +0000 Subject: Fix pointer arithmetic botch. Pointer subtraction to find size only works with char pointers. Noticed by: jhb@ Sponsored by: Netflix, Inc --- usr.sbin/efivar/efiutil.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'usr.sbin/efivar') diff --git a/usr.sbin/efivar/efiutil.c b/usr.sbin/efivar/efiutil.c index a7dfc2474b04..0ccf2950df2a 100644 --- a/usr.sbin/efivar/efiutil.c +++ b/usr.sbin/efivar/efiutil.c @@ -116,6 +116,8 @@ bindump(uint8_t *data, size_t datalen) #define LOAD_OPTION_ACTIVE 1 +#define SIZE(dp, edp) (size_t)((intptr_t)(void *)edp - (intptr_t)(void *)dp) + void efi_print_load_option(uint8_t *data, size_t datalen, int Aflag, int bflag, int uflag) { @@ -159,9 +161,8 @@ efi_print_load_option(uint8_t *data, size_t datalen, int Aflag, int bflag, int u ucs2_to_utf8(descr, &str); printf("%s", str); free(str); - while (dp < edp && (size_t)(edp - dp) > sizeof(efidp_header)) { - efidp_format_device_path(buf, sizeof(buf), dp, - (intptr_t)(void *)edp - (intptr_t)(void *)dp); + while (dp < edp && SIZE(dp, edp) > sizeof(efidp_header)) { + efidp_format_device_path(buf, sizeof(buf), dp, SIZE(dp, edp)); dp = (efidp)((char *)dp + efidp_size(dp)); printf(" %s\n", buf); } -- cgit v1.2.3